Skip to content

Commit 17dd778

Browse files
committed
Refine logging in StompErrorHandler
Avoid a full stacktrace at ERROR level for a client message that could not be sent to a MessageChannel. See gh-26026
1 parent 21f9d05 commit 17dd778

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,13 @@ else if (StompCommand.UNSUBSCRIBE.equals(command)) {
328328
}
329329
catch (Throwable ex) {
330330
if (logger.isErrorEnabled()) {
331-
logger.error("Failed to send client message to application via MessageChannel" +
332-
" in session " + session.getId() + ". Sending STOMP ERROR to client.", ex);
331+
String errorText = "Failed to send message to MessageChannel in session " + session.getId();
332+
if (logger.isDebugEnabled()) {
333+
logger.debug(errorText, ex);
334+
}
335+
else {
336+
logger.error(errorText + ":" + ex.getMessage());
337+
}
333338
}
334339
handleError(session, ex, message);
335340
}

0 commit comments

Comments
 (0)