Incorrect remote partitioning sample in the documentation [BATCH-2730]

[spring-projects-issues]

Mahmoud Ben Hassine opened BATCH-2730 and commented

There are some minor errors in the remote partitioning section of the documentation. The code example of the partitioned step is incorrect:

public Job personJob() {
                return jobBuilderFactory.get("personJob")
                                .start(stepBuilderFactory.get("step1.master")
                                                .partitioner(partitionHandler())
                                                .build())
                                .build();
 }

while it should be:

public Job personJob() {
                return jobBuilderFactory.get("personJob")
                                .start(stepBuilderFactory.get("step1.master")
                                                .partitioner("step1.worker", partitioner())
                                                .partitionHandler(partitionHandler())
                                                .build())
                                .build();
 }

Moreover, the code example shows all beans in the same bloc without mentioning which ones should be declared on the master side and which ones should be declared on the worker side. This is confusing. It should either use profiles or separate the master's configuration from the worker's configuration.

Finally, it would be great to add a remote partitioning sample to the spring-batch-samples module (current samples show only local partitioning).

---

Affects: 4.0.1, 4.1.0.M1

Referenced from: pull request #612, and commits 5730f38, 2c5b7b5

Backported to: 4.0.2