Skip to content

Commit c136821

Browse files
committed
feature: change the CONTINUE button to SplitButton to support editing/splitting original commit (#767)
Signed-off-by: leo <[email protected]>
1 parent 941ea4a commit c136821

File tree

5 files changed

+78
-10
lines changed

5 files changed

+78
-10
lines changed

src/Resources/Locales/en_US.axaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,7 @@
680680
<x:String x:Key="Text.WorkingCopy.CommitAndPush" xml:space="preserve">COMMIT &amp; PUSH</x:String>
681681
<x:String x:Key="Text.WorkingCopy.CommitMessageHelper" xml:space="preserve">Template/Histories</x:String>
682682
<x:String x:Key="Text.WorkingCopy.CommitTip" xml:space="preserve">Trigger click event</x:String>
683+
<x:String x:Key="Text.WorkingCopy.CommitToEdit" xml:space="preserve">Commit (Edit)</x:String>
683684
<x:String x:Key="Text.WorkingCopy.CommitWithAutoStage" xml:space="preserve">Stage all changes and commit</x:String>
684685
<x:String x:Key="Text.WorkingCopy.ConfirmCommitWithoutFiles" xml:space="preserve">Empty commit detected! Do you want to continue (--allow-empty)?</x:String>
685686
<x:String x:Key="Text.WorkingCopy.Conflicts" xml:space="preserve">CONFLICTS DETECTED</x:String>

src/Resources/Locales/zh_CN.axaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,7 @@
684684
<x:String x:Key="Text.WorkingCopy.CommitAndPush" xml:space="preserve">提交并推送</x:String>
685685
<x:String x:Key="Text.WorkingCopy.CommitMessageHelper" xml:space="preserve">历史输入/模板</x:String>
686686
<x:String x:Key="Text.WorkingCopy.CommitTip" xml:space="preserve">触发点击事件</x:String>
687+
<x:String x:Key="Text.WorkingCopy.CommitToEdit" xml:space="preserve">提交(修改原始提交)</x:String>
687688
<x:String x:Key="Text.WorkingCopy.CommitWithAutoStage" xml:space="preserve">自动暂存所有变更并提交</x:String>
688689
<x:String x:Key="Text.WorkingCopy.ConfirmCommitWithoutFiles" xml:space="preserve">提交未包含变更文件!是否继续(--allow-empty)?</x:String>
689690
<x:String x:Key="Text.WorkingCopy.Conflicts" xml:space="preserve">检测到冲突</x:String>

src/Resources/Locales/zh_TW.axaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,7 @@
683683
<x:String x:Key="Text.WorkingCopy.CommitAndPush" xml:space="preserve">提交並推送</x:String>
684684
<x:String x:Key="Text.WorkingCopy.CommitMessageHelper" xml:space="preserve">歷史輸入/範本</x:String>
685685
<x:String x:Key="Text.WorkingCopy.CommitTip" xml:space="preserve">觸發點擊事件</x:String>
686+
<x:String x:Key="Text.WorkingCopy.CommitToEdit" xml:space="preserve">提交(修改現有提交)</x:String>
686687
<x:String x:Key="Text.WorkingCopy.CommitWithAutoStage" xml:space="preserve">自動暫存全部變更並提交</x:String>
687688
<x:String x:Key="Text.WorkingCopy.ConfirmCommitWithoutFiles" xml:space="preserve">未包含任何檔案變更! 您是否仍要提交 (--allow-empty)?</x:String>
688689
<x:String x:Key="Text.WorkingCopy.Conflicts" xml:space="preserve">檢測到衝突</x:String>

src/Resources/Styles.axaml

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,66 @@
519519
<Style Selector="Button.flat:disabled">
520520
<Setter Property="Background" Value="{DynamicResource Brush.FlatButton.Background}"/>
521521
</Style>
522+
523+
<Style Selector="SplitButton">
524+
<Setter Property="MinHeight" Value="24"/>
525+
<Setter Property="Template">
526+
<ControlTemplate>
527+
<Grid>
528+
<Grid.ColumnDefinitions>
529+
<ColumnDefinition Width="*" />
530+
<ColumnDefinition Width="1" />
531+
<ColumnDefinition Width="Auto" />
532+
</Grid.ColumnDefinitions>
533+
534+
<Button x:Name="PART_PrimaryButton"
535+
Grid.Column="0"
536+
Classes="flat primary"
537+
MinWidth="32"
538+
HorizontalAlignment="Stretch"
539+
VerticalAlignment="Stretch"
540+
Content="{TemplateBinding Content}"
541+
ContentTemplate="{TemplateBinding ContentTemplate}"
542+
Command="{TemplateBinding Command}"
543+
CommandParameter="{TemplateBinding CommandParameter}"
544+
CornerRadius="3,0,0,3"
545+
Padding="{TemplateBinding Padding}"
546+
Focusable="False"
547+
KeyboardNavigation.IsTabStop="False" />
548+
549+
<Button x:Name="PART_SecondaryButton"
550+
Grid.Column="2"
551+
Classes="flat primary"
552+
Width="32"
553+
CornerRadius="0,3,3,0"
554+
Padding="0"
555+
Focusable="False"
556+
HorizontalAlignment="Stretch"
557+
VerticalAlignment="Stretch"
558+
KeyboardNavigation.IsTabStop="False">
559+
<Path Height="12" Width="12"
560+
Margin="0,4,0,0"
561+
Fill="{DynamicResource AccentButtonForeground}"
562+
Data="{DynamicResource Icons.Down}"/>
563+
</Button>
564+
</Grid>
565+
</ControlTemplate>
566+
</Setter>
567+
568+
<Style Selector="^:disabled /template/ Button">
569+
<Setter Property="BorderThickness" Value="1"/>
570+
<Setter Property="BorderBrush" Value="{DynamicResource Brush.Border2}"/>
571+
<Setter Property="Background" Value="Transparent"/>
572+
</Style>
573+
574+
<Style Selector="^:disabled TextBlock">
575+
<Setter Property="Foreground" Value="{DynamicResource Brush.FG2}"/>
576+
</Style>
577+
578+
<Style Selector="^:disabled Path">
579+
<Setter Property="Fill" Value="{DynamicResource Brush.FG2}"/>
580+
</Style>
581+
</Style>
522582

523583
<Style Selector="aes|SearchPanel">
524584
<Setter Property="Template">

src/Views/WorkingCopy.axaml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -243,16 +243,21 @@
243243
Content="{DynamicResource Text.WorkingCopy.Amend}"/>
244244

245245
<v:LoadingIcon Grid.Column="5" Width="18" Height="18" IsVisible="{Binding IsCommitting}"/>
246-
247-
<Button Grid.Column="6"
248-
Classes="flat primary"
249-
Content="{DynamicResource Text.Repository.Continue}"
250-
Height="28"
251-
Margin="8,0,0,0"
252-
Padding="8,0"
253-
Command="{Binding ContinueMerge}"
254-
IsVisible="{Binding InProgressContext, Converter={x:Static ObjectConverters.IsNotNull}}"
255-
IsEnabled="{Binding !HasUnsolvedConflicts}"/>
246+
247+
<SplitButton Grid.Column="6"
248+
Content="{DynamicResource Text.Repository.Continue}"
249+
Height="28"
250+
Margin="8,0,0,0"
251+
Padding="8,0"
252+
Command="{Binding ContinueMerge}"
253+
IsVisible="{Binding InProgressContext, Converter={x:Static ObjectConverters.IsNotNull}}"
254+
IsEnabled="{Binding !HasUnsolvedConflicts}">
255+
<SplitButton.Flyout>
256+
<MenuFlyout>
257+
<MenuItem Header="{DynamicResource Text.WorkingCopy.CommitToEdit}" Command="{Binding Commit}"/>
258+
</MenuFlyout>
259+
</SplitButton.Flyout>
260+
</SplitButton>
256261

257262
<Button Grid.Column="6"
258263
Classes="flat primary"

0 commit comments

Comments
 (0)