feature: supports searching revision files (#775)

love-linger · love-linger · commit 894f3e9b033f · 2024-12-02T21:44:15.000+08:00
diff --git a/src/Commands/QueryRevisionFileNames.cs b/src/Commands/QueryRevisionFileNames.cs
@@ -1,19 +1,19 @@
 ﻿namespace SourceGit.Commands
 {
-    public class QueryCurrentRevisionFiles : Command
+    public class QueryRevisionFileNames : Command
     {
-        public QueryCurrentRevisionFiles(string repo)
+        public QueryRevisionFileNames(string repo, string revision)
         {
             WorkingDirectory = repo;
             Context = repo;
-            Args = "ls-tree -r --name-only HEAD";
+            Args = $"ls-tree -r -z --name-only {revision}";
         }
 
         public string[] Result()
         {
             var rs = ReadToEnd();
             if (rs.IsSuccess)
-                return rs.StdOut.Split('\n', System.StringSplitOptions.RemoveEmptyEntries);
+                return rs.StdOut.Split('\0', System.StringSplitOptions.RemoveEmptyEntries);
 
             return [];
         }
diff --git a/src/Commands/QueryRevisionObjects.cs b/src/Commands/QueryRevisionObjects.cs
@@ -12,19 +12,35 @@ public QueryRevisionObjects(string repo, string sha, string parentFolder)
         {
             WorkingDirectory = repo;
             Context = repo;
-            Args = $"ls-tree {sha}";
+            Args = $"ls-tree -z {sha}";
 
             if (!string.IsNullOrEmpty(parentFolder))
                 Args += $" -- \"{parentFolder}\"";
         }
 
         public List<Models.Object> Result()
         {
-            Exec();
+            var rs = ReadToEnd();
+            if (rs.IsSuccess)
+            {
+                var start = 0;
+                var end = rs.StdOut.IndexOf('\0', start);
+                while (end > 0)
+                {
+                    var line = rs.StdOut.Substring(start, end - start);
+                    Parse(line);
+                    start = end + 1;
+                    end = rs.StdOut.IndexOf('\0', start);
+                }
+
+                if (start < rs.StdOut.Length)
+                    Parse(rs.StdOut.Substring(start));
+            }
+
             return _objects;
         }
 
-        protected override void OnReadline(string line)
+        private void Parse(string line)
         {
             var match = REG_FORMAT().Match(line);
             if (!match.Success)
diff --git a/src/Resources/Locales/en_US.axaml b/src/Resources/Locales/en_US.axaml
@@ -121,6 +121,7 @@
   <x:String x:Key="Text.CommitDetail.Changes.Search" xml:space="preserve">Search Changes...</x:String>
   <x:String x:Key="Text.CommitDetail.Files" xml:space="preserve">FILES</x:String>
   <x:String x:Key="Text.CommitDetail.Files.LFS" xml:space="preserve">LFS File</x:String>
+  <x:String x:Key="Text.CommitDetail.Files.Search" xml:space="preserve">Search Files...</x:String>
   <x:String x:Key="Text.CommitDetail.Files.Submodule" xml:space="preserve">Submodule</x:String>
   <x:String x:Key="Text.CommitDetail.Info" xml:space="preserve">INFORMATION</x:String>
   <x:String x:Key="Text.CommitDetail.Info.Author" xml:space="preserve">AUTHOR</x:String>
diff --git a/src/Resources/Locales/zh_CN.axaml b/src/Resources/Locales/zh_CN.axaml
@@ -124,6 +124,7 @@
   <x:String x:Key="Text.CommitDetail.Changes.Search" xml:space="preserve">查找变更...</x:String>
   <x:String x:Key="Text.CommitDetail.Files" xml:space="preserve">文件列表</x:String>
   <x:String x:Key="Text.CommitDetail.Files.LFS" xml:space="preserve">LFS文件</x:String>
+  <x:String x:Key="Text.CommitDetail.Files.Search" xml:space="preserve">查找文件...</x:String>
   <x:String x:Key="Text.CommitDetail.Files.Submodule" xml:space="preserve">子模块</x:String>
   <x:String x:Key="Text.CommitDetail.Info" xml:space="preserve">基本信息</x:String>
   <x:String x:Key="Text.CommitDetail.Info.Author" xml:space="preserve">修改者</x:String>
diff --git a/src/Resources/Locales/zh_TW.axaml b/src/Resources/Locales/zh_TW.axaml
@@ -124,6 +124,7 @@
   <x:String x:Key="Text.CommitDetail.Changes.Search" xml:space="preserve">搜尋變更...</x:String>
   <x:String x:Key="Text.CommitDetail.Files" xml:space="preserve">檔案列表</x:String>
   <x:String x:Key="Text.CommitDetail.Files.LFS" xml:space="preserve">LFS 檔案</x:String>
+  <x:String x:Key="Text.CommitDetail.Files.Search" xml:space="preserve">搜尋檔案...</x:String>
   <x:String x:Key="Text.CommitDetail.Files.Submodule" xml:space="preserve">子模組</x:String>
   <x:String x:Key="Text.CommitDetail.Info" xml:space="preserve">基本資訊</x:String>
   <x:String x:Key="Text.CommitDetail.Info.Author" xml:space="preserve">作者</x:String>
diff --git a/src/ViewModels/CommitDetail.cs b/src/ViewModels/CommitDetail.cs
@@ -82,7 +82,7 @@ public AvaloniaList<string> Children
         {
             get;
             private set;
-        } = new AvaloniaList<string>();
+        } = [];
 
         public string SearchChangeFilter
         {
@@ -106,13 +106,68 @@ public AvaloniaList<Models.CommitLink> WebLinks
         {
             get;
             private set;
-        } = new AvaloniaList<Models.CommitLink>();
+        } = [];
 
         public AvaloniaList<Models.IssueTrackerRule> IssueTrackerRules
         {
             get => _repo.Settings?.IssueTrackerRules;
         }
 
+        public string RevisionFileSearchFilter
+        {
+            get => _revisionFileSearchFilter;
+            set
+            {
+                if (SetProperty(ref _revisionFileSearchFilter, value))
+                {
+                    RevisionFileSearchSuggestion.Clear();
+                    
+                    if (!string.IsNullOrEmpty(value))
+                    {
+                        if (_revisionFiles.Count == 0)
+                        {
+                            var sha = Commit.SHA;
+
+                            Task.Run(() =>
+                            {
+                                var files = new Commands.QueryRevisionFileNames(_repo.FullPath, sha).Result();
+
+                                Dispatcher.UIThread.Invoke(() => {
+                                    if (sha == Commit.SHA)
+                                    {
+                                        _revisionFiles.Clear();
+                                        _revisionFiles.AddRange(files);
+                                        UpdateRevisionFileSearchSuggestion();
+                                    }
+                                });
+                            });
+                        }
+                        else
+                        {
+                            UpdateRevisionFileSearchSuggestion();
+                        }
+                    }
+                    else
+                    {
+                        IsRevisionFileSearchSuggestionOpen = false;
+                        GC.Collect();
+                    }
+                }
+            }
+        }
+
+        public AvaloniaList<string> RevisionFileSearchSuggestion
+        {
+            get;
+            private set;
+        } = [];
+
+        public bool IsRevisionFileSearchSuggestionOpen
+        {
+            get => _isRevisionFileSearchSuggestionOpen;
+            set => SetProperty(ref _isRevisionFileSearchSuggestionOpen, value);
+        }
+
         public CommitDetail(Repository repo)
         {
             _repo = repo;
@@ -147,17 +202,23 @@ public void Cleanup()
         {
             _repo = null;
             _commit = null;
+
             if (_changes != null)
                 _changes.Clear();
             if (_visibleChanges != null)
                 _visibleChanges.Clear();
             if (_selectedChanges != null)
                 _selectedChanges.Clear();
+
             _signInfo = null;
             _searchChangeFilter = null;
             _diffContext = null;
             _viewRevisionFileContent = null;
             _cancelToken = null;
+
+            WebLinks.Clear();
+            _revisionFiles.Clear();
+            RevisionFileSearchSuggestion.Clear();
         }
 
         public void NavigateTo(string commitSHA)
@@ -175,6 +236,11 @@ public void ClearSearchChangeFilter()
             SearchChangeFilter = string.Empty;
         }
 
+        public void ClearRevisionFileSearchFilter()
+        {
+            RevisionFileSearchFilter = string.Empty;
+        }
+
         public Models.Commit GetParent(string sha)
         {
             return new Commands.QuerySingleCommit(_repo.FullPath, sha).Result();
@@ -543,13 +609,17 @@ public ContextMenu CreateRevisionFileContextMenu(Models.Object file)
         private void Refresh()
         {
             _changes = null;
+            _revisionFiles.Clear();
+
             FullMessage = string.Empty;
             SignInfo = null;
             Changes = [];
             VisibleChanges = null;
             SelectedChanges = null;
             ViewRevisionFileContent = null;
             Children.Clear();
+            RevisionFileSearchFilter = string.Empty;
+            IsRevisionFileSearchSuggestionOpen = false;
 
             if (_commit == null)
                 return;
@@ -716,6 +786,24 @@ private void TryToAddContextMenuItemsForGitLFS(ContextMenu menu, string path)
             menu.Items.Add(new MenuItem() { Header = "-" });
         }
 
+        private void UpdateRevisionFileSearchSuggestion()
+        {
+            var suggestion = new List<string>();
+            foreach (var file in _revisionFiles)
+            {
+                if (file.Contains(_revisionFileSearchFilter, StringComparison.OrdinalIgnoreCase) && 
+                    file.Length != _revisionFileSearchFilter.Length)
+                    suggestion.Add(file);
+
+                if (suggestion.Count >= 100)
+                    break;
+            }
+
+            RevisionFileSearchSuggestion.Clear();
+            RevisionFileSearchSuggestion.AddRange(suggestion);
+            IsRevisionFileSearchSuggestionOpen = suggestion.Count > 0;
+        }
+
         [GeneratedRegex(@"^version https://git-lfs.github.com/spec/v\d+\r?\noid sha256:([0-9a-f]+)\r?\nsize (\d+)[\r\n]*$")]
         private static partial Regex REG_LFS_FORMAT();
 
@@ -736,5 +824,8 @@ private void TryToAddContextMenuItemsForGitLFS(ContextMenu menu, string path)
         private DiffContext _diffContext = null;
         private object _viewRevisionFileContent = null;
         private Commands.Command.CancelToken _cancelToken = null;
+        private List<string> _revisionFiles = [];
+        private string _revisionFileSearchFilter = string.Empty;
+        private bool _isRevisionFileSearchSuggestionOpen = false;
     }
 }
diff --git a/src/ViewModels/Repository.cs b/src/ViewModels/Repository.cs
@@ -2147,7 +2147,7 @@ private void UpdateCurrentRevisionFilesForSearchSuggestion()
             {
                 Task.Run(() =>
                 {
-                    var files = new Commands.QueryCurrentRevisionFiles(_fullpath).Result();
+                    var files = new Commands.QueryRevisionFileNames(_fullpath, "HEAD").Result();
                     Dispatcher.UIThread.Invoke(() =>
                     {
                         if (_searchCommitFilterType != 3)
diff --git a/src/Views/RevisionFileTreeView.axaml.cs b/src/Views/RevisionFileTreeView.axaml.cs
@@ -144,6 +144,68 @@ public RevisionFileTreeView()
             InitializeComponent();
         }
 
+        public void SetSearchResult(string file)
+        {
+            _rows.Clear();
+            _searchResult.Clear();
+
+            var rows = new List<ViewModels.RevisionFileTreeNode>();
+            if (string.IsNullOrEmpty(file))
+            {
+                MakeRows(rows, _tree, 0);
+            }
+            else
+            {
+                var vm = DataContext as ViewModels.CommitDetail;
+                if (vm == null || vm.Commit == null)
+                    return;
+
+                var objects = vm.GetRevisionFilesUnderFolder(file);
+                if (objects == null || objects.Count != 1)
+                    return;
+
+                var routes = file.Split('/', StringSplitOptions.None);
+                if (routes.Length == 1)
+                {
+                    _searchResult.Add(new ViewModels.RevisionFileTreeNode
+                    {
+                        Backend = objects[0]
+                    });
+                }
+                else
+                {
+                    var last = _searchResult;
+                    var prefix = string.Empty;
+                    for (var i = 0; i < routes.Length - 1; i++)
+                    {
+                        var folder = new ViewModels.RevisionFileTreeNode
+                        {
+                            Backend = new Models.Object
+                            {
+                                Type = Models.ObjectType.Tree,
+                                Path = prefix + routes[i],
+                            },
+                            IsExpanded = true,
+                        };
+
+                        last.Add(folder);
+                        last = folder.Children;
+                        prefix = folder.Backend + "/";
+                    }
+
+                    last.Add(new ViewModels.RevisionFileTreeNode
+                    {
+                        Backend = objects[0]
+                    });
+                }
+
+                MakeRows(rows, _searchResult, 0);
+            }
+
+            _rows.AddRange(rows);
+            GC.Collect();
+        }
+
         public void ToggleNodeIsExpanded(ViewModels.RevisionFileTreeNode node)
         {
             _disableSelectionChangingEvent = true;
@@ -189,6 +251,7 @@ protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs chang
             {
                 _tree.Clear();
                 _rows.Clear();
+                _searchResult.Clear();
 
                 var vm = DataContext as ViewModels.CommitDetail;
                 if (vm == null || vm.Commit == null)
@@ -308,5 +371,6 @@ private void MakeRows(List<ViewModels.RevisionFileTreeNode> rows, List<ViewModel
         private List<ViewModels.RevisionFileTreeNode> _tree = [];
         private AvaloniaList<ViewModels.RevisionFileTreeNode> _rows = [];
         private bool _disableSelectionChangingEvent = false;
+        private List<ViewModels.RevisionFileTreeNode> _searchResult = [];
     }
 }
diff --git a/src/Views/RevisionFiles.axaml b/src/Views/RevisionFiles.axaml
diff --git a/src/Views/RevisionFiles.axaml.cs b/src/Views/RevisionFiles.axaml.cs

Original file line number	Diff line number	Diff line change
`@@ -1,19 +1,19 @@`
`1`	`1`	`namespace SourceGit.Commands`
`2`	`2`	`{`
`3`		`- public class QueryCurrentRevisionFiles : Command`
	`3`	`+ public class QueryRevisionFileNames : Command`
`4`	`4`	`{`
`5`		`- public QueryCurrentRevisionFiles(string repo)`
	`5`	`+ public QueryRevisionFileNames(string repo, string revision)`
`6`	`6`	`{`
`7`	`7`	`WorkingDirectory = repo;`
`8`	`8`	`Context = repo;`
`9`		`- Args = "ls-tree -r --name-only HEAD";`
	`9`	`+ Args = $"ls-tree -r -z --name-only {revision}";`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`public string[] Result()`
`13`	`13`	`{`
`14`	`14`	`var rs = ReadToEnd();`
`15`	`15`	`if (rs.IsSuccess)`
`16`		`- return rs.StdOut.Split('\n', System.StringSplitOptions.RemoveEmptyEntries);`
	`16`	`+ return rs.StdOut.Split('\0', System.StringSplitOptions.RemoveEmptyEntries);`
`17`	`17`
`18`	`18`	`return [];`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2147,7 +2147,7 @@ private void UpdateCurrentRevisionFilesForSearchSuggestion()`
`2147`	`2147`	`{`
`2148`	`2148`	`Task.Run(() =>`
`2149`	`2149`	`{`
`2150`		`- var files = new Commands.QueryCurrentRevisionFiles(_fullpath).Result();`
	`2150`	`+ var files = new Commands.QueryRevisionFileNames(_fullpath, "HEAD").Result();`
`2151`	`2151`	`Dispatcher.UIThread.Invoke(() =>`
`2152`	`2152`	`{`
`2153`	`2153`	`if (_searchCommitFilterType != 3)`