Skip to content

Commit 7c69d58

Browse files
committed
Fix CSS specificity issue with easymde's css
PR go-gitea#18069 introduced a regression in certain overwritten editor styles because the dynamic loading of easymde.min.css causes its's style to apply after our supposed override styles. Solve this by bundling the styles into index.css. We should later aim to completely replace easymde.min.css completely with our own styles so there are no more conflicts.
1 parent 21ed4fd commit 7c69d58

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

web_src/js/features/comp/EasyMDE.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ export async function importEasyMDE() {
2525
// https://github.com/codemirror/CodeMirror/issues/5484
2626
// https://github.com/codemirror/CodeMirror/issues/4838
2727

28+
// easymde's css is loaded via webpack config
2829
const [{default: EasyMDE}, {default: CodeMirror}] = await Promise.all([
2930
import(/* webpackChunkName: "easymde" */'easymde'),
3031
import(/* webpackChunkName: "codemirror" */'codemirror'),
31-
import(/* webpackChunkName: "easymde" */'easymde/dist/easymde.min.css'),
3232
]);
3333

3434
// CodeMirror plugins must be loaded by a "Plain browser env"

webpack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export default {
4646
resolve(__dirname, 'web_src/js/jquery.js'),
4747
resolve(__dirname, 'web_src/fomantic/build/semantic.js'),
4848
resolve(__dirname, 'web_src/js/index.js'),
49+
resolve(__dirname, 'node_modules/easymde/dist/easymde.min.css'),
4950
resolve(__dirname, 'web_src/fomantic/build/semantic.css'),
5051
resolve(__dirname, 'web_src/less/misc.css'),
5152
resolve(__dirname, 'web_src/less/index.less'),

0 commit comments

Comments
 (0)