Including the RollingFileSink initialization in the try..catch so that any errors in the creation are included in the self log

Author: pvandervelde

src/Serilog.Sinks.File/FileLoggerConfigurationExtensions.cs

@@ -528,13 +528,13 @@ static LoggerConfiguration ConfigureFile(
 
             ILogEventSink sink;
 
-            if (rollOnFileSizeLimit || rollingInterval != RollingInterval.Infinite)
+            try
             {
-                sink = new RollingFileSink(path, formatter, fileSizeLimitBytes, retainedFileCountLimit, encoding, buffered, shared, rollingInterval, rollOnFileSizeLimit, hooks, retainedFileTimeLimit);
-            }
-            else
-            {
-                try
+                if (rollOnFileSizeLimit || rollingInterval != RollingInterval.Infinite)
+                {
+                    sink = new RollingFileSink(path, formatter, fileSizeLimitBytes, retainedFileCountLimit, encoding, buffered, shared, rollingInterval, rollOnFileSizeLimit, hooks, retainedFileTimeLimit);
+                }
+                else
                 {
                     if (shared)
                     {
@@ -546,16 +546,17 @@ static LoggerConfiguration ConfigureFile(
                     {
                         sink = new FileSink(path, formatter, fileSizeLimitBytes, encoding, buffered, hooks);
                     }
+
                 }
-                catch (Exception ex)
-                {
-                    SelfLog.WriteLine("Unable to open file sink for {0}: {1}", path, ex);
+            }
+            catch (Exception ex)
+            {
+                SelfLog.WriteLine("Unable to open file sink for {0}: {1}", path, ex);
 
-                    if (propagateExceptions)
-                        throw;
+                if (propagateExceptions)
+                    throw;
 
-                    return addSink(new NullSink(), LevelAlias.Maximum, null);
-                }
+                return addSink(new NullSink(), LevelAlias.Maximum, null);
             }
 
             if (flushToDiskInterval.HasValue)