clippy: warn on FFI not using new traits

Author: Lorak-mmk

scylla-rust-wrapper/clippy.toml

@@ -0,0 +1,21 @@
+disallowed-methods = [
+    "std::boxed::Box::from_raw",
+    "std::boxed::Box::from_raw_in",
+    "std::boxed::Box::into_raw",
+    "std::boxed::Box::into_raw_with_allocator",
+
+    "std::sync::Arc::as_ptr",
+    "std::sync::Arc::decrement_strong_count",
+    "std::sync::Arc::from_raw",
+    "std::sync::Arc::increment_strong_count",
+    "std::sync::Arc::into_raw",
+
+    "std::rc::Rc::as_ptr",
+    "std::rc::Rc::decrement_strong_count",
+    "std::rc::Rc::from_raw",
+    "std::rc::Rc::increment_strong_count",
+    "std::rc::Rc::into_raw",
+
+    "const_ptr::as_ref",
+    "mut_ptr::as_mut"
+]

scylla-rust-wrapper/src/argconv.rs

@@ -78,18 +78,23 @@ pub(crate) use make_c_str;
 /// the memory associated with the pointer using corresponding driver's API function.
 pub trait BoxFFI {
     fn into_ptr(self: Box<Self>) -> *mut Self {
+        #[allow(clippy::disallowed_methods)]
         Box::into_raw(self)
     }
     unsafe fn from_ptr(ptr: *mut Self) -> Box<Self> {
+        #[allow(clippy::disallowed_methods)]
         Box::from_raw(ptr)
     }
     unsafe fn maybe_as_ref<'a>(ptr: *const Self) -> Option<&'a Self> {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_ref()
     }
     unsafe fn as_ref<'a>(ptr: *const Self) -> &'a Self {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_ref().unwrap()
     }
     unsafe fn as_mut_ref<'a>(ptr: *mut Self) -> &'a mut Self {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_mut().unwrap()
     }
     unsafe fn free(ptr: *mut Self) {
@@ -105,22 +110,29 @@ pub trait BoxFFI {
 /// with the pointer using corresponding driver's API function.
 pub trait ArcFFI {
     fn as_ptr(self: &Arc<Self>) -> *const Self {
+        #[allow(clippy::disallowed_methods)]
         Arc::as_ptr(self)
     }
     fn into_ptr(self: Arc<Self>) -> *const Self {
+        #[allow(clippy::disallowed_methods)]
         Arc::into_raw(self)
     }
     unsafe fn from_ptr(ptr: *const Self) -> Arc<Self> {
+        #[allow(clippy::disallowed_methods)]
         Arc::from_raw(ptr)
     }
     unsafe fn cloned_from_ptr(ptr: *const Self) -> Arc<Self> {
+        #[allow(clippy::disallowed_methods)]
         Arc::increment_strong_count(ptr);
+        #[allow(clippy::disallowed_methods)]
         Arc::from_raw(ptr)
     }
     unsafe fn maybe_as_ref<'a>(ptr: *const Self) -> Option<&'a Self> {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_ref()
     }
     unsafe fn as_ref<'a>(ptr: *const Self) -> &'a Self {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_ref().unwrap()
     }
     unsafe fn free(ptr: *const Self) {
@@ -141,6 +153,7 @@ pub trait RefFFI {
         self as *const Self
     }
     unsafe fn as_ref<'a>(ptr: *const Self) -> &'a Self {
+        #[allow(clippy::disallowed_methods)]
         ptr.as_ref().unwrap()
     }
 }

scylla-rust-wrapper/src/future.rs

@@ -489,6 +489,7 @@ mod tests {
     //   the future, and execute its callback
     #[test]
     #[ntest::timeout(600)]
+    #[allow(clippy::disallowed_methods)]
     fn test_cass_future_callback() {
         unsafe {
             const ERROR_MSG: &str = "NOBODY EXPECTED SPANISH INQUISITION";