Skip to content

Commit ec98623

Browse files
committed
integration: use NTS by default
By default, the tests used SimpleStrategy if there was a single DC. Using SimpleStrategy is discouraged. Apart from that, Scylla seems to disable the tablets by default for SimpleStrategy keyspaces - we want to prevent that. For Cassandra, we still will be using SimpleStrategy.
1 parent 19ad449 commit ec98623

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

tests/src/integration/integration.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,9 @@ std::string Integration::default_replication_strategy() {
268268
replication_strategy_s << "'NetworkTopologyStrategy', 'dc1': " << number_dc1_nodes_ << ", "
269269
<< "'dc2': " << number_dc2_nodes_;
270270
} else {
271-
replication_strategy_s << "'SimpleStrategy', 'replication_factor': ";
271+
// Currently we use Cassandra 3.11.19, which disallows the use of `replication_factor` with NTS.
272+
std::string strategy = Options::is_scylla() ? "'NetworkTopologyStrategy'" : "'SimpleStrategy'";
273+
replication_strategy_s << strategy << ", 'replication_factor': ";
272274

273275
// Ensure the replication factor has not been overridden or already set
274276
if (replication_factor_ == 0) {

0 commit comments

Comments
 (0)