Skip to content

Merge linting phases into one megaphase #18708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szymon-rd opened this issue Oct 17, 2023 · 1 comment · Fixed by #20894
Closed

Merge linting phases into one megaphase #18708

szymon-rd opened this issue Oct 17, 2023 · 1 comment · Fixed by #20894
Assignees
Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug
Milestone

Comments

@szymon-rd
Copy link
Contributor

szymon-rd commented Oct 17, 2023

Unused, shadowing, and other future linting warns should be calculated in one megaphase. Right now, an undiagnosed issue is preventing us from doing that. The issue should be diagnosed and phases put in one megaphase

@som-snytt
Copy link
Contributor

In my version, the problem was the way CheckShadowing was detecting the class type params it wanted. I kludged it a bit.

@sjrd sjrd closed this as completed in 9cb97ec Jan 28, 2025
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug
Projects
None yet
3 participants