Show all kinds of package objects as packages

We missed package objects created for top-level definitions.

Author: nicolasstucki

compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala

@@ -1105,7 +1105,7 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {
         nameString(sym)
       else if sym.is(Package) then
         fullNameString(sym)
-      else if (sym.is(ModuleClass) && sym.isPackageObject && sym.name.stripModuleClassSuffix == tpnme.PACKAGE)
+      else if (sym.is(ModuleClass) && sym.isPackageObject && sym.name.isPackageObjectName)
         nameString(sym.owner.name)
       else if (sym.is(ModuleClass))
         nameString(sym.name.stripModuleClassSuffix) + idString(sym)

tests/neg/i12573.check

@@ -1,9 +1,9 @@
 -- [E008] Not Found Error: tests/neg/i12573.scala:23:38 ----------------------------------------------------------------
 23 |val w: Value[8] = DFBits(Value[8](8)).getDFType.width // error
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |         value getDFType is not a member of DFBits[(8 : Int)].
-   |         Extension methods were tried, but the search failed with:
+   |                value getDFType is not a member of DFBits[(8 : Int)].
+   |                Extension methods were tried, but the search failed with:
    |
-   |             method getDFType cannot be accessed as a member of DFType.type from package object i12573$package.
-   |              Access to protected method getDFType not permitted because enclosing package object i12573$package
-   |              is not a subclass of object DFType where target is defined
+   |                    method getDFType cannot be accessed as a member of DFType.type from package object <empty>.
+   |                     Access to protected method getDFType not permitted because enclosing package object <empty>
+   |                     is not a subclass of object DFType where target is defined

tests/neg/not-accessible.check

@@ -9,12 +9,12 @@
 -- [E173] Reference Error: tests/neg/not-accessible.scala:13:23 --------------------------------------------------------
 13 |    def test(a: A) = a.x // error
    |                     ^^^
-   |               value x cannot be accessed as a member of (a : foo.A) from package object not-accessible$package.
+   |                     value x cannot be accessed as a member of (a : foo.A) from package object bar.
 -- [E173] Reference Error: tests/neg/not-accessible.scala:5:21 ---------------------------------------------------------
 5 |  def test(a: A) = a.x // error
   |                   ^^^
-  |                 value x cannot be accessed as a member of (a : foo.A) from package object not-accessible$package.
+  |                   value x cannot be accessed as a member of (a : foo.A) from package object foo.
 -- [E173] Reference Error: tests/neg/not-accessible.scala:15:23 --------------------------------------------------------
 15 |def test(a: foo.A) = a.x // error
    |                     ^^^
-   |               value x cannot be accessed as a member of (a : foo.A) from package object not-accessible$package.
+   |                     value x cannot be accessed as a member of (a : foo.A) from package object <empty>.