Skip to content

scala.swing.Action title should really be text. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacobsallan opened this issue Oct 19, 2014 · 0 comments
Closed

scala.swing.Action title should really be text. #31

jacobsallan opened this issue Oct 19, 2014 · 0 comments

Comments

@jacobsallan
Copy link
Contributor

Action contains the code
def title: String = ifNull(peer.getValue(javax.swing.Action.NAME),"")
def title_=(t: String) { peer.putValue(javax.swing.Action.NAME, t) }

The javax swing JavaDoc for Action http://docs.oracle.com/javase/7/docs/api/javax/swing/Action.html
manipulates the component property "text", not "title".

Action is not in the class inheritance hierarchy of any other component, so adding text defs is safe. Removing title opens up a backwards compatibility issue.

@Sciss Sciss closed this as completed in 29d7685 Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant