Skip to content

Issue for issue templates #11831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
som-snytt opened this issue Dec 20, 2019 · 7 comments · Fixed by #11893
Closed

Issue for issue templates #11831

som-snytt opened this issue Dec 20, 2019 · 7 comments · Fixed by #11893
Labels
enhancement fixed in Scala 3 This issue does not exist in the Scala 3 compiler (https://github.com/lampepfl/dotty/)

Comments

@som-snytt
Copy link

som-snytt commented Dec 20, 2019

Scala 2 almost got an issue template via One small nudge for a bug, a giant time-saver for us.

Since dotty will bring the fancy templates we envy, and probably more guidance will be required for posting Scala 2 bugs during and after the transition, perhaps we could install issue templates now.

For example, library enhancements could receive the 3.2 milestone. The template could ask for the result in dotty, or just a checkbox for Fixed in dotty?

Now that there is an issue for issue templates, someone may step up and contribute.

@som-snytt som-snytt added enhancement fixed in Scala 3 This issue does not exist in the Scala 3 compiler (https://github.com/lampepfl/dotty/) labels Dec 20, 2019
@SethTisue
Copy link
Member

@eed3si9n is on Team Issue Template. you two can bond over it

I think any templates should be kept short & sweet, and I think the Dotty ones are good examples of that

@eed3si9n
Copy link
Member

Dotty uses GitHub's new Choose UI - https://github.com/lampepfl/dotty/issues/new/choose
I do that on sbt as well - https://github.com/sbt/sbt/issues/new/choose

If @SethTisue would be on board with Team Issue Template if we adopted Dotty's template (sans feature request and syntax highlight reports), I'd be happy to do so.

Would that convince @lrytz?

@som-snytt
Copy link
Author

We propose the template eschew "Description" or minimized code for:

I contrived a fairly trivial example to illustrate my point as follows:

https://stackoverflow.com/questions/59596386/protected-method-that-takes-an-abstract-super-class-instance-and-the-access-to/59596881#comment105358506_59596386

@lrytz
Copy link
Member

lrytz commented Jan 8, 2020

I see value in reporters having to select "🐛 Bug report", and provide other categories like "question" or "feature request" where the template would say "please don't open an issue here, instead go there".

The issue template for bugs itself, I personally still consider it unnecessary overhead.

@som-snytt
Copy link
Author

Take a gander (scroll down).

@eed3si9n
Copy link
Member

Exhibit #11891

For Example this is the input Data, where I need relation tree like below output :

(large JSON)

@eed3si9n
Copy link
Member

Here's another PR for this - #11893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in Scala 3 This issue does not exist in the Scala 3 compiler (https://github.com/lampepfl/dotty/)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants