Skip to content

Commit 02d4f63

Browse files
authored
Merge pull request #2 from itsmekumari/e2e-cloudsqlmysql
e2e CloudSqlMySql
2 parents 012c0b6 + 1478679 commit 02d4f63

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

e2e-test/src/test/java/io/cdap/plugin/cloudsqlmysql/actions/package-info.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
* the License.
1515
*/
1616
/**
17-
* Package contains the runner for the CloudSqlMySQL features.
17+
* Package contains step actions for the CloudSqlMySQL features.
1818
*/
1919
package io.cdap.plugin.cloudsqlmysql.actions;
20-
21-

e2e-test/src/test/java/io/cdap/plugin/cloudsqlmysql/locators/package-info.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
* the License.
1515
*/
1616
/**
17-
* Package contains the runner for the cloudSqlMySql features.
17+
* Package contains the locators for the cloudSqlMySql features.
1818
*/
1919
package io.cdap.plugin.cloudsqlmysql.locators;
20-
21-

e2e-test/src/test/java/io/cdap/plugin/cloudsqlmysql/stepsdesign/CloudSqlMySql.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ public class CloudSqlMySql implements CdfHelper {
5454
public static String folderName;
5555
List<String> propertiesSchemaColumnList = new ArrayList<>();
5656
Map<String, String> sourcePropertiesOutputSchema = new HashMap<>();
57-
static int i = 0;
58-
GcpClient gcpClient = new GcpClient();
5957
int cloudSqlMySqlPreRecordsCount;
6058
int cloudSqlMySqlPostRecordsCount;
6159

@@ -497,7 +495,7 @@ public void closeTheBigQueryProperties() {
497495
@Then("Get Count of no of records transferred to BigQuery in {string}")
498496
public void getCountOfNoOfRecordsTransferredToBigQueryIn(String table) throws IOException, InterruptedException {
499497
int countRecords;
500-
countRecords = gcpClient.countBqQuery(E2ETestUtils.pluginProp(table));
498+
countRecords = GcpClient.countBqQuery(E2ETestUtils.pluginProp(table));
501499
BeforeActions.scenario.write("**********No of Records Transferred******************:" + countRecords);
502500
Assert.assertEquals(countRecords, recordOut());
503501
}
@@ -515,7 +513,7 @@ public void validateCountOfRecordsTransferredFromImportQueryToBigQueryIn(String
515513

516514
@Then("Delete the table {string}")
517515
public void deleteTheTable(String table) throws IOException, InterruptedException {
518-
gcpClient.dropBqQuery(E2ETestUtils.pluginProp(table));
516+
GcpClient.dropBqQuery(E2ETestUtils.pluginProp(table));
519517
BeforeActions.scenario.write("Table Deleted Successfully");
520518
}
521519

@@ -794,7 +792,6 @@ public void verifyTheFolderCreatedInWithBucketName(String projectID, String buck
794792
folderName = E2ETestUtils.listObjects(E2ETestUtils.pluginProp(projectID),
795793
E2ETestUtils.pluginProp(bucketName));
796794
Assert.assertTrue(folderName != null);
797-
798795
}
799796

800797
@Then("Validate the count of records transferred from BigQuery {string} to CloudSqlMySql {string}")

0 commit comments

Comments
 (0)