Skip to content

Update Modal design to reflect latest SLDS blueprint #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xulingzhihou opened this issue Aug 5, 2024 · 0 comments · Fixed by #3148
Closed

Update Modal design to reflect latest SLDS blueprint #3147

xulingzhihou opened this issue Aug 5, 2024 · 0 comments · Fixed by #3148

Comments

@xulingzhihou
Copy link
Contributor

xulingzhihou commented Aug 5, 2024

SLDS blueprint has updated modals to have a new white background behind the 'X' to address accessibility concerns for color contrast. Currently in design system react the button is coded to be a reverse button which results in the 'X' to be invisible.

New design:
image

Issue:
image

  • If you are working on the problem. Issues may be closed within 30 days if no one is assigned. Maintainers work on this project 20-30 hours per week and have their own prioritized backlog.
  • How to duplicate a bug. Line numbers or code to paste into the documentation site examples is helpful.
  • If you are a Salesforce employee. You should also create a duplicate work item in your internal ticket system and link to this issue.
  • If you plan to work on a new component. Please propose props after reviewing at newly written components and docs/codebase-overview.md.

For Salesforce platform questions, please visit https://success.salesforce.com, https://partners.salesforce.com, or https://salesforce.stackexchange.com

This project uses SLDS markup, but you should submit HTML/CSS issues to https://github.com/salesforce-ux/design-system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant