Skip to content

some fixes for pycodestyle linter #32279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fchapoton opened this issue Jul 26, 2021 · 10 comments
Closed

some fixes for pycodestyle linter #32279

fchapoton opened this issue Jul 26, 2021 · 10 comments

Comments

@fchapoton
Copy link
Contributor

Also

  • fix one lgtm suggestion
  • remove some #py2 / #py3 doctest tags

CC: @tscrim @slel @kliem

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: e79e59e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32279

@fchapoton fchapoton added this to the sage-9.4 milestone Jul 26, 2021
@fchapoton
Copy link
Contributor Author

New commits:

5f756e0fix pycodestyle warnings (polishing)
b3dc3f0one lgtm-suggested fix in pq_trees.py
e79e59esome py2 / py3 doctest tagging removal

@fchapoton
Copy link
Contributor Author

Commit: e79e59e

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32279

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, and one linter is green (out of 3)

about pyflakes warnings from patchbot : one is harmless, the other is serious but should be handled elsewhere

please review

@tscrim
Copy link
Collaborator

tscrim commented Jul 27, 2021

comment:3

That one in categories/finite_dimensional_algebras_with_basis.py is bad and needs to be fixed. It can be left to another ticket.

@tscrim
Copy link
Collaborator

tscrim commented Jul 27, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 27, 2021

comment:4

Replying to @tscrim:

That one in categories/finite_dimensional_algebras_with_basis.py is bad and needs to be fixed. It can be left to another ticket.

This is now #32283.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@jhpalmieri
Copy link
Member

comment:6

Do you know if this one has been fixed anywhere?

diff --git a/src/sage/combinat/posets/poset_examples.py b/src/sage/combinat/posets/poset_examples.py
index 67d9949db1..7913c50f7d 100644
--- a/src/sage/combinat/posets/poset_examples.py
+++ b/src/sage/combinat/posets/poset_examples.py
@@ -155,7 +155,7 @@ class Posets(metaclass=ClasscallMetaclass):
 
     @staticmethod
     def BooleanLattice(n, facade=None, use_subsets=False):
-        """
+        r"""
         Return the Boolean lattice containing `2^n` elements.
 
         - ``n`` -- integer; number of elements will be `2^n`

The code as is produces

[combinat ] <unknown>:158: DeprecationWarning: invalid escape sequence \{

@slel

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Sep 1, 2021

Changed branch from u/chapoton/32279 to e79e59e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants