Skip to content

Unicode art for symbolics #18482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vbraun opened this issue May 24, 2015 · 25 comments
Closed

Unicode art for symbolics #18482

vbraun opened this issue May 24, 2015 · 25 comments

Comments

@vbraun
Copy link
Member

vbraun commented May 24, 2015

Example:

sage: %display unicode_art
sage: integral(exp(sqrt(x))/(x+pi), x)
⌠          
⎮    ___   
⎮  ╲╱ x    
⎮ ℯ        
⎮ ────── dx
⎮ x + π    
⌡          

Depends on #18357

CC: @videlec

Component: symbolics

Author: Volker Braun

Branch/Commit: db1c0e4

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/18482

@vbraun vbraun added this to the sage-6.8 milestone May 24, 2015
@vbraun
Copy link
Member Author

vbraun commented May 24, 2015

Dependencies: #18357

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented May 24, 2015

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented May 24, 2015

Branch: u/vbraun/unicode_art_for_symbolics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Commit: ef5b6a4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

ef5b6a4fix docbuild and doctests in sage.typeset

@videlec
Copy link
Contributor

videlec commented Jun 1, 2015

Work Issues: rebase

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 2, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3f68c33Merge 6.8.beta2 into #18482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 2, 2015

Changed commit from ef5b6a4 to 3f68c33

@vbraun
Copy link
Member Author

vbraun commented Jun 2, 2015

Changed work issues from rebase to none

@vbraun
Copy link
Member Author

vbraun commented Jun 2, 2015

comment:8

fixed

@videlec
Copy link
Contributor

videlec commented Jun 9, 2015

Changed commit from 3f68c33 to db1c0e4

@videlec
Copy link
Contributor

videlec commented Jun 9, 2015

Changed branch from u/vbraun/unicode_art_for_symbolics to public/18482

@videlec
Copy link
Contributor

videlec commented Jun 9, 2015

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Jun 9, 2015

comment:9

Hello,

Waiting for the patchbot final check. But this is good for me.

Vincent


New commits:

f13355fTrac #18482: remove trailing Volker's whitespaces
db1c0e4Trac #18482: fix sage_object.pyx

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

e01e088Merge branch 'develop' into t/18482/public/18482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2015

Changed commit from db1c0e4 to e01e088

@rwst
Copy link
Contributor

rwst commented Jun 18, 2015

comment:11

Patchbot passes with only some long test timeouts. The patchbot ascii plugin fails and I have difficulties making doc-pdf in ru/tutorial but that could be spurious.

@videlec
Copy link
Contributor

videlec commented Jun 18, 2015

comment:12

replying to comment:11: What did you do in e01e088? If this is only a merge commit you can remove it. If there is something else it needs to be separated.

@rwst
Copy link
Contributor

rwst commented Jun 19, 2015

comment:13

Replying to @videlec:

replying to comment:11: What did you do in e01e088? If this is only a merge commit you can remove it. If there is something else it needs to be separated.

The branch link was red, so I merged develop. Indeed there was no merge conflict when I did. I'll remove it so we can see if it goes red again.

@rwst
Copy link
Contributor

rwst commented Jun 19, 2015

Changed branch from public/18482 to public/18482-1

@rwst
Copy link
Contributor

rwst commented Jun 19, 2015

Changed commit from e01e088 to db1c0e4

@rwst
Copy link
Contributor

rwst commented Jun 19, 2015

comment:15

It's red again, see for yourself.

@videlec
Copy link
Contributor

videlec commented Jun 19, 2015

comment:16

Replying to @rwst:

It's red again, see for yourself.

I see. It was discussed on sage-devel. The merge test of the trac plugin is less concilient than the default git merge.

But still, I do not see the need of an additional commit.

@vbraun
Copy link
Member Author

vbraun commented Jun 20, 2015

Changed branch from public/18482-1 to db1c0e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants