Skip to content

Add is_finite method for the Symbolic Ring #18054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bgrenet opened this issue Mar 25, 2015 · 8 comments
Closed

Add is_finite method for the Symbolic Ring #18054

bgrenet opened this issue Mar 25, 2015 · 8 comments
Labels
c: symbolics p: major / 3 t: enhancement
Milestone
sage-6.6

Comments

@bgrenet
Copy link
Contributor

bgrenet commented Mar 25, 2015

In this ticket, I add a method is_finite() to the SymbolicRing. The necessity for such a method occurs to me in #17840. Of course, the answer is False.

Component: symbolics

Keywords: is_finite symbolic_ring

Author: Bruno Grenet

Branch/Commit: 3378995

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/18054
@bgrenet bgrenet added this to the sage-6.6 milestone Mar 25, 2015
@bgrenet
Copy link
Contributor Author

bgrenet commented Mar 25, 2015

Branch: u/bruno/ticket/add_is_finite

@bgrenet
Copy link
Contributor Author

bgrenet commented Mar 25, 2015

Commit: 5dcebe4

@pjbruin
Copy link
Contributor

pjbruin commented Mar 25, 2015

Reviewer: Peter Bruin

@pjbruin
Copy link
Contributor

pjbruin commented Mar 25, 2015

comment:3

Looks good; the only comment I have is that the two lines inside the EXAMPLES block should be indented by 4 spaces.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 25, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3378995Indentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 25, 2015

Changed commit from 5dcebe4 to 3378995

@bgrenet
Copy link
Contributor Author

bgrenet commented Mar 25, 2015

comment:5

Replying to @pjbruin:

Looks good; the only comment I have is that the two lines inside the EXAMPLES block should be indented by 4 spaces.

Done!

@vbraun
Copy link
Member

vbraun commented Apr 14, 2015

Changed branch from u/bruno/ticket/add_is_finite to 3378995

@vbraun vbraun closed this as completed in 1357e94 Apr 14, 2015
@bgrenet bgrenet mentioned this issue Mar 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.6
Development

No branches or pull requests
3 participants
@vbraun @bgrenet @pjbruin