Skip to content

wrong piecewise convolution #17793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwst opened this issue Feb 17, 2015 · 5 comments
Closed

wrong piecewise convolution #17793

rwst opened this issue Feb 17, 2015 · 5 comments

Comments

@rwst
Copy link
Contributor

rwst commented Feb 17, 2015

This doctest tests against a wrong result, the resulting curve must have a quadratic part:

            sage: f = piecewise([[(-1,1),1]])                             ## example 2
            sage: g = piecewise([[(0,3),x]])
            sage: f.convolution(g)
            Piecewise defined function with 3 parts, [[(-1, 1), 0], [(1, 2), -3/2*x], [(2, 4), -3/2*x]]

From numerical investigation it seems the solution would be piecewise(x|-->1/2*x^2 + x + 1/2 on (-1/2, 1), x|-->2*x on (1, 2), x|-->-1/2*x^2 + x + 4 on (2, 7/2); x).

This works in the new piecewise from #14801.

The ticket is for documentary reasons because a new piecewise code is being worked on in #14801.

CC: @wdjoyner @kcrisman @jondo @vbraun @slel @mkoeppe @eviatarbach @rwst

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/17793

@rwst rwst added this to the sage-6.5 milestone Feb 17, 2015
@kcrisman
Copy link
Member

comment:1

See also #12123 (possibly the same?) Actually, the fix should be pretty easy once one understands the code, but I gave up here.

@rwst

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 25, 2016

comment:3

Works in the new piecewise from #14801.
Dup of #12123, which is why I'm setting this to "dup/needs review"

@mkoeppe mkoeppe removed this from the sage-6.5 milestone Jun 25, 2016
@embray
Copy link
Contributor

embray commented Aug 30, 2016

comment:6

Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants