Skip to content

Commit 4c9b28b

Browse files
committed
ci: remove client-server.py, cut over to rust tests
This commit removes the existing `client-server.py` integration test and updates CI to run the new Rust-based integration tests.
1 parent 97f0fb5 commit 4c9b28b

File tree

4 files changed

+19
-250
lines changed

4 files changed

+19
-250
lines changed

.github/workflows/test.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,9 @@ jobs:
8282
run: cmake -S . -B build
8383
- name: Build, debug configuration
8484
run: cmake --build build --config Debug
85-
- name: Client-server test, debug
86-
run: python tests/client-server.py build/tests/Debug/client.exe build/tests/Debug/server.exe
85+
env:
86+
CLIENT_BINARY: build/tests/Debug/client.exe
87+
SERVER_BINARY: build/tests/Debug/server.exe
8788

8889
test-windows-cmake-release:
8990
name: Windows CMake, Release configuration
@@ -98,8 +99,9 @@ jobs:
9899
run: cmake -S . -B build
99100
- name: Build, release configuration
100101
run: cmake --build build --config Release
101-
- name: Client-server test, release
102-
run: python tests/client-server.py build/tests/Release/client.exe build/tests/Release/server.exe
102+
env:
103+
CLIENT_BINARY: build/tests/Release/client.exe
104+
SERVER_BINARY: build/tests/Release/server.exe
103105

104106
ensure-header-updated:
105107
runs-on: ubuntu-latest
@@ -149,6 +151,9 @@ jobs:
149151
- name: Install rust toolchain
150152
uses: dtolnay/rust-toolchain@nightly
151153

154+
- name: Build client/server binaries
155+
run: make target/client target/server
156+
152157
- name: cargo test (debug; all features; -Z minimal-versions)
153158
run: cargo -Z minimal-versions test --all-features --locked
154159

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ endif
2828

2929
all: target/client target/server
3030

31-
test: all test-rust
32-
./tests/client-server.py ./target/client ./target/server
33-
34-
test-rust:
31+
test: all
3532
${CARGO} test --locked
3633

34+
integration: all
35+
${CARGO} test --locked -- --ignored
36+
3737
target:
3838
mkdir -p $@
3939

@@ -75,4 +75,4 @@ format-check:
7575
! -wholename './src/rustls.h' | \
7676
xargs clang-format --dry-run -Werror -i
7777

78-
.PHONY: all clean test format format-check
78+
.PHONY: all clean test integration format format-check

Makefile.Windows

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ test: all
4040
$(call green_msg, Running 'cargo test')
4141
cargo test --locked
4242

43+
integration: all
44+
$(call green_msg, Running 'cargo test -- --ignored')
45+
cargo test --locked -- --ignored
46+
4347
$(RUSTLS_LIB): src/lib.rs Cargo.toml
4448
$(call green_msg, Building '$@')
4549
RUSTFLAGS="--print native-static-libs" cargo build --release --locked
@@ -63,3 +67,4 @@ define link_EXE
6367
@echo
6468
endef
6569

70+
.PHONY: all clean test integration

tests/client-server.py

Lines changed: 0 additions & 241 deletions
This file was deleted.

0 commit comments

Comments
 (0)