Skip to content

log::info! called before initializing logger #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChocolateLoverRaj opened this issue Nov 17, 2024 · 1 comment · Fixed by #476
Closed

log::info! called before initializing logger #475

ChocolateLoverRaj opened this issue Nov 17, 2024 · 1 comment · Fixed by #476

Comments

@ChocolateLoverRaj
Copy link
Contributor

bootloader/uefi/src/main.rs

Line 534 in af99f0f

log::info!("UEFI boot");

This line doesn't do anything write now. It basically functions as a comment. It should either be

  • Removed
  • Moved to be after calling init_logger (I don't think it's necessary since

    bootloader/uefi/src/main.rs

    Line 115 in af99f0f

    log::info!("UEFI bootloader started");
  • Turned into a comment
@Freax13
Copy link
Member

Freax13 commented Nov 23, 2024

Makes sense, feel free to open a PR.

@ChocolateLoverRaj ChocolateLoverRaj mentioned this issue Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "UEFI boot" log message ChocolateLoverRaj/bootloader
2 participants
@Freax13 @ChocolateLoverRaj