Skip to content

arm-linux-androideabi #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubdos opened this issue Mar 9, 2018 · 6 comments
Closed

arm-linux-androideabi #363

rubdos opened this issue Mar 9, 2018 · 6 comments

Comments

@rubdos
Copy link
Contributor

rubdos commented Mar 9, 2018

I'm using stdsimd as an optional dependency for curve25519-dalek. Works fine on Intel, but I seem to be having issues compiling for Android.

   Compiling stdsimd v0.0.4
error[E0432]: unresolved import `coresimd::__unstable_detect_feature`
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/stdsimd-0.0.4/src/lib.rs:133:9
    |
133 | pub use coresimd::__unstable_detect_feature;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `__unstable_detect_feature` in the root

error: aborting due to previous error

I wasn't sure whether this was a known issue, so I'm dropping it off here... I've seen the issue about the missing CI, but no open issues on Android support.

Easy reproducer:

cargo build --features=yolocrypto on https://github.com/dalek-cryptography/curve25519-dalek.git , I'm doing this with Android API 18, NDK r16b.

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 9, 2018

Currently run-time feature detection "should work" on Android as is. It is currently explicitly disabled because of lack of CI support for it. I'll send a PR to enable it once the MIPS PR #365 one is merged, but just because your code might compile does not mean that it will work properly.

Adding CI support for android should not be very hard though. I'll might get to it later today and send a PR with that as well.

@rubdos
Copy link
Contributor Author

rubdos commented Mar 9, 2018

Adding CI support for android should not be very hard though. I'll might get to it later today and send a PR with that as well.

Feel free to tag me in the PR; interested in the follow up.

@alexcrichton
Copy link
Member

@rubdos this error message is for the stdsimd crate on crates.io, but this crate is now available through libstd via std::arch and std::simd, and I believe the Android target works in there?

@rubdos
Copy link
Contributor Author

rubdos commented Mar 9, 2018

@rubdos this error message is for the stdsimd crate on crates.io, but this crate is now available through libstd via std::arch and std::simd, and I believe the Android target works in there?

Then it's actually curve25519-dalek that's outdated; I'll give it a try. I'll reopen if it's not the case; this sounds very plausible.

@rubdos rubdos closed this as completed Mar 9, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 10, 2018

@rubdos let us know here if it works.

@rubdos
Copy link
Contributor Author

rubdos commented Mar 10, 2018

@gnzlbg it seems like the implementation on curve25519-dalek uses pretty old stdsimd code, so I'm pretty certain that that's the case. I might give it a shot in the future, but it's not a priority :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants