Review feedback

Author: wesleywiser

Cargo.toml

@@ -4,12 +4,13 @@ members = ["fuzz"]
 [workspace.package]
 version = "0.0.0"
 edition = "2021"
+license = "Apache-2.0 WITH LLVM-exception"
 
 [package]
 name = "rustc_apfloat"
-license = "Apache-2.0 WITH LLVM-exception"
 version.workspace = true
 edition.workspace = true
+license.workspace = true
 
 [dependencies]
 bitflags = "1.3.2"

LICENSE-DETAILS.md

@@ -70,8 +70,8 @@ As the total diff is only 6 lines of code (excluding changes to APInt unit tests
 
 The original LLVM code appears to be available as Apache 2 with LLVM Exception and so our port of this code is licensed as such.
 
-A few additional patches (code cleanups and backports of upstream LLVM changes) have been made on top of the initial port.
-The authors of these patches have also agreed to allow their code to be used under the Apache 2 with LLVM Exception license (backports from LLVM only include changes made after LLVM's licensing switch on 2019-01-19).
+A few additional patches (code cleanups and performance improvements) have been made on top of the initial port.
+The authors of these patches have also agreed to allow their code to be used under the Apache 2 with LLVM Exception license.
 
 Subsequent work on this crate has advanced the state of the port from the original commit.
 Reviewing the set of upstream LLVM changes after revision `f3598e8fca83ccfb11f58ec7957c229e349765e3` and before the relicensing on 2019-01-19 reveals 41 changes all of which LLVM has relicensing agreements with their authors.

README.md

@@ -1,13 +1,5 @@
 # `rustc_apfloat` (Rust port of C++ `llvm::APFloat` library)
 
-## Licensing
-
-This project is licensed under the [Apache 2] with [LLVM exception] license.
-For a more complete discussion of this project's licensing, see [LICENSE-DETAILS.md](./LICENSE-DETAILS.md).
-
-[Apache 2]: https://spdx.org/licenses/Apache-2.0.html
-[LLVM Exception]: https://spdx.org/licenses/LLVM-exception.html
-
 ## 🚧 Work In Progress 🚧
 
 **NOTE**: the repo (and [`rustc_apfloat-git-history-extraction`](https://github.com/LykenSol/rustc_apfloat-git-history-extraction)) might be public already, but only for convenience of discussion, see [relevant Zulip topic](https://rust-lang.zulipchat.com/#narrow/stream/231349-t-core.2Flicensing/topic/apfloat) for more details.
@@ -55,3 +47,11 @@ To visualize the fuzzing testcases, you can use the `decode` subcommand:
 cargo run -p rustc_apfloat-fuzz decode fuzz/out-foo/default/crashes/*
 ```
 (this will work even while `cargo afl fuzz`, i.e. AFL++, is running)
+
+## Licensing
+
+This project is licensed under the [Apache 2] with [LLVM exception] license.
+For a more complete discussion of this project's licensing, see [LICENSE-DETAILS.md](./LICENSE-DETAILS.md).
+
+[Apache 2]: https://spdx.org/licenses/Apache-2.0.html
+[LLVM Exception]: https://spdx.org/licenses/LLVM-exception.html