Skip to content

Commit 81f6f7d

Browse files
Clarify column headers on self-profile page
1 parent 48ffab7 commit 81f6f7d

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

site/static/detailed-query.html

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
padding-left: 1em;
1414
}
1515

16+
body.hide-incr .incr {
17+
display: none;
18+
}
19+
1620
body.hide-delta .delta {
1721
display: none;
1822
}
@@ -50,17 +54,19 @@
5054
<h3 id="title"></h3>
5155
<p>Totals row '%total time' is as a comparison to the 'cpu-clock' stat (we do not use
5256
wall-time as we want to account for parallelism).</p>
57+
<p>Executions do not include cached executions.</p>
5358
<table>
5459
<thead>
5560
<tr id="table-header">
5661
<th data-sort-idx="1" data-default-sort-dir="1">Query/Function</th>
57-
<th data-sort-idx="2" data-default-sort-dir="-1">Time</th>
62+
<th data-sort-idx="2" data-default-sort-dir="-1">Time (s)</th>
5863
<th data-sort-idx="10" data-default-sort-dir="-1">% Total Time</th>
59-
<th class="delta">Δ</th>
60-
<th data-sort-idx="5" data-default-sort-dir="-1">Full Executions</th>
61-
<th class="delta">Δ</th>
62-
<th data-sort-idx="7" data-default-sort-dir="-1" title="Incremental loading time">Loading</th>
63-
<th class="delta">Δ</th>
64+
<th class="delta">Execution time delta</th>
65+
<th data-sort-idx="5" data-default-sort-dir="-1">Executions</th>
66+
<th class="delta">Executions delta</th>
67+
<th class="incr" data-sort-idx="7"
68+
data-default-sort-dir="-1" title="Incremental loading time">Incremental loading (s)</th>
69+
<th class="incr" class="delta">Incremental loading delta</th>
6470
</tr>
6571
</thead>
6672
<tbody id="primary-table">
@@ -144,6 +150,13 @@ <h3 id="title"></h3>
144150
let inner = th.innerHTML;
145151
th.innerHTML = `<a href="${query_string_for_state(clickState)}">${inner}</a>`;
146152
}
153+
154+
if (!state.run_name.includes("incr-")) {
155+
// No need to show incremental columns if not showing
156+
// incremental data.
157+
document.body.classList.add("hide-incr");
158+
}
159+
147160
let table = document.getElementById("primary-table");
148161
let idx = 0;
149162
for (let element of [data.profile.totals, ...data.profile.query_data]) {
@@ -189,16 +202,17 @@ <h3 id="title"></h3>
189202
} else {
190203
td(row, "-", true);
191204
}
192-
td(row, to_seconds(cur.incremental_load_time).toFixed(3));
205+
td(row,
206+
to_seconds(cur.incremental_load_time).toFixed(3)).classList.add("incr");
193207
if (prev) {
194208
td(row,
195209
fmt_delta(
196210
to_seconds(prev.incremental_load_time),
197211
to_seconds(cur.incremental_load_time),
198212
),
199-
true);
213+
true).classList.add("incr");
200214
} else {
201-
td(row, "-", true);
215+
td(row, "-", true).classList.add("incr");
202216
}
203217
table.appendChild(row);
204218
idx += 1;

0 commit comments

Comments
 (0)