Skip to content

Commit 2bd73fa

Browse files
lqdMark-Simulacrum
authored andcommitted
reverse how the try commits are added to the queue
Adding the parent first should make the full run's data available when the commit itself is done being benchmarked. That should fix the early notifications.
1 parent c7aabe6 commit 2bd73fa

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

site/src/load.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -543,13 +543,9 @@ impl InputData {
543543
sha, parent_sha, ..
544544
}| {
545545
let mut ret = Vec::new();
546-
ret.push((
547-
Commit {
548-
sha: sha.as_str().into(),
549-
date: Date::ymd_hms(2001, 01, 01, 0, 0, 0),
550-
},
551-
MissingReason::TryCommit,
552-
));
546+
// Enqueue the `TryParent` commit before the `TryCommit` itself, so that
547+
// all of the `try` run's data is complete when the benchmark results
548+
// of that commit are available.
553549
if let Some(commit) = commits.iter().find(|c| c.sha == *parent_sha.as_str()) {
554550
ret.push((commit.clone(), MissingReason::TryParent));
555551
} else {
@@ -558,6 +554,13 @@ impl InputData {
558554
// days for the most part so we don't have artifacts for it anymore anyway;
559555
// in that case, just ignore this "error".
560556
}
557+
ret.push((
558+
Commit {
559+
sha: sha.as_str().into(),
560+
date: Date::ymd_hms(2001, 01, 01, 0, 0, 0),
561+
},
562+
MissingReason::TryCommit,
563+
));
561564
ret
562565
},
563566
)

0 commit comments

Comments
 (0)