Skip to content

Clippy toolstate is broken #74911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mati865 opened this issue Jul 29, 2020 · 4 comments
Closed

Clippy toolstate is broken #74911

mati865 opened this issue Jul 29, 2020 · 4 comments
Labels
C-bug Category: This is a bug.

Comments

@mati865
Copy link
Member

mati865 commented Jul 29, 2020

https://rust-lang-nursery.github.io/rust-toolstate/ reports Clippy as test fail on both platforms but it's passing the tests on x86_64-gnu-tools right now.

@mati865 mati865 added the C-bug Category: This is a bug. label Jul 29, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2020

Clippy toolstate is no longer being recorded because it is required to pass now. The clippy entry should maybe just be removed from the toolstate tracker?

@mati865
Copy link
Member Author

mati865 commented Jul 29, 2020

Are the tests required to pass now, I remember Clippy was effectively build pass for some time after the migration.

@Mark-Simulacrum
Copy link
Member

Yeah I'm not actually sure why it's showing up to be honest, but it seems like a bug upstream -- we're not recording it in this repository anymore https://github.com/alexcrichton/rust/blob/2c28244cf0fc9868f55070e55b8f332d196eaf3f/src/bootstrap/toolstate.rs#L281-L286.

I'm moving this to toolstate repo.

@Mark-Simulacrum
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants