-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use --edition instead of -Zedition (stabilize edition flag, kind of) #49591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@klnusbaum want to work on this? I suspect this would have been better to do before rust-lang/cargo#5214 landed, but I kinda forgot, sorry 😄 You may want to factor it out such that I'd like this to exist in a week or two, so if you don't have the time lmk and I'll just land it. |
Sure! I'd love to work on this. I'll try to take a wack at it sometime this week :) |
What are the files that I should be looking at here? |
It uses getopts, I suspect you want to imitate what's done for the The macros are for codegen/debugging options afaict, and we're moving this option out of there. |
@klnusbaum btw, you seem to be helping out a bunch with epoch/edition related stuff. You may want to join https://gitter.im/rust-lang/WG-epoch , and let me know if you want more interesting things to work on! |
I'm starting to understand this a little more. Hoping to have something by the end of the weekend. |
I think we can mark this as done. @Manishearth mentioned that cargo needs to be switched to now use |
For reference, this was addressed with #50080 |
Fixed by #50080 (For future reference, write "fixes #foo" in the PR body so it gets auto-closed. Or at least mention the issue so it gets cross linked) |
Currently, Rust lets you specify the edition via
-Zunstable-options -Zedition
.I'd like to stabilize the flag as
--edition
, such that non-nightly Rust can only pass down--edition=2015
, but other versions can specify anything there.The text was updated successfully, but these errors were encountered: