-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix failing rpass-valgrind test #29896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
P-high
High priority
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
cc @nagisa |
cc @rust-lang/compiler (I wish labelling T-compiler did this automatically) |
What's the actual errors here? Running valgrind without flags reports:
And running with more flags:
(which looks benign) |
Happens with simple check-stage1-rpass-valgrind
|
Ah I think that may have been fixed by #29897 |
Confirmed - we now pass all rpass-valgrind tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P-high
High priority
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
This is blocking turning valgrind tests back on.
exit-flushes.rs is apparently the culprit.
cc @edunham, @nikomatsakis, @alexcrichton
(p-high since it is blocking fixing our test infra)
The text was updated successfully, but these errors were encountered: