Skip to content

Commit 34d5b54

Browse files
committed
Replaced a comment mentioning a fixed issue
Replaced it with a comment mentioning the rationale for checking the discriminants first.
1 parent 7721d46 commit 34d5b54

File tree

1 file changed

+5
-3
lines changed
  • src/libsyntax/ext/deriving/generic

1 file changed

+5
-3
lines changed

src/libsyntax/ext/deriving/generic/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,10 +1042,12 @@ impl<'a> MethodDef<'a> {
10421042
/// variants where all of the variants match, and one catch-all for
10431043
/// when one does not match.
10441044
1045+
/// As an optimization we generate code which checks whether all variants
1046+
/// match first which makes llvm see that C-like enums can be compiled into
1047+
/// a simple equality check (for PartialEq).
1048+
10451049
/// The catch-all handler is provided access the variant index values
1046-
/// for each of the self-args, carried in precomputed variables. (Nota
1047-
/// bene: the variant index values are not necessarily the
1048-
/// discriminant values. See issue #15523.)
1050+
/// for each of the self-args, carried in precomputed variables.
10491051
10501052
/// ```{.text}
10511053
/// let __self0_vi = unsafe {

0 commit comments

Comments
 (0)