Simplify is_broadcast

faern · faern · commit 312cdb423351 · 2018-07-30T20:52:37.000+02:00
diff --git a/src/libstd/net/ip.rs b/src/libstd/net/ip.rs
@@ -587,8 +587,7 @@ impl Ipv4Addr {
     /// ```
     #[stable(since = "1.7.0", feature = "ip_17")]
     pub fn is_broadcast(&self) -> bool {
-        self.octets()[0] == 255 && self.octets()[1] == 255 &&
-        self.octets()[2] == 255 && self.octets()[3] == 255
+        self == &Self::BROADCAST
     }
 
     /// Returns [`true`] if this address is in a range designated for documentation.

Original file line number	Diff line number	Diff line change
`@@ -587,8 +587,7 @@ impl Ipv4Addr {`
`587`	`587`	/// ```
`588`	`588`	`#[stable(since = "1.7.0", feature = "ip_17")]`
`589`	`589`	`pub fn is_broadcast(&self) -> bool {`
`590`		`- self.octets()[0] == 255 && self.octets()[1] == 255 &&`
`591`		`- self.octets()[2] == 255 && self.octets()[3] == 255`
	`590`	`+ self == &Self::BROADCAST`
`592`	`591`	`}`
`593`	`592`
`594`	`593`	/// Returns [`true`] if this address is in a range designated for documentation.