Skip to content

Commit 235a5f7

Browse files
borsbors
committed
Auto merge of #57896 - oli-obk:permissive_existence, r=cramertj
 Be more permissive with required bounds on existential types fixes #54184 r? @pnkfelix
2 parents eac0908 + eb98d31 commit 235a5f7

39 files changed

+548
-79
lines changed

‎src/librustc/ich/impls_ty.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,11 @@ impl_stable_hash_for!(struct ty::FnSig<'tcx> {
237237
abi
238238
});
239239

240+
impl_stable_hash_for!(struct ty::ResolvedOpaqueTy<'tcx> {
241+
concrete_type,
242+
substs
243+
});
244+
240245
impl<'a, 'gcx, T> HashStable<StableHashingContext<'a>> for ty::Binder<T>
241246
where T: HashStable<StableHashingContext<'a>>
242247
{

‎src/librustc/infer/opaque_types/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ pub struct OpaqueTypeDecl<'tcx> {
2626
///
2727
/// winds up desugared to:
2828
///
29-
/// abstract type Foo<'x, T>: Trait<'x>
29+
/// abstract type Foo<'x, X>: Trait<'x>
3030
/// fn foo<'a, 'b, T>() -> Foo<'a, T>
3131
///
3232
/// then `substs` would be `['a, T]`.

‎src/librustc/ty/context.rs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,17 @@ impl<'a, V> LocalTableInContextMut<'a, V> {
317317
}
318318
}
319319

320+
/// All information necessary to validate and reveal an `impl Trait` or `existential Type`
321+
#[derive(RustcEncodable, RustcDecodable, Debug)]
322+
pub struct ResolvedOpaqueTy<'tcx> {
323+
/// The revealed type as seen by this function.
324+
pub concrete_type: Ty<'tcx>,
325+
/// Generic parameters on the opaque type as passed by this function.
326+
/// For `existential type Foo<A, B>; fn foo<T, U>() -> Foo<T, U> { .. }` this is `[T, U]`, not
327+
/// `[A, B]`
328+
pub substs: &'tcx Substs<'tcx>,
329+
}
330+
320331
#[derive(RustcEncodable, RustcDecodable, Debug)]
321332
pub struct TypeckTables<'tcx> {
322333
/// The HirId::owner all ItemLocalIds in this table are relative to.
@@ -419,7 +430,7 @@ pub struct TypeckTables<'tcx> {
419430

420431
/// All the existential types that are restricted to concrete types
421432
/// by this function
422-
pub concrete_existential_types: FxHashMap<DefId, Ty<'tcx>>,
433+
pub concrete_existential_types: FxHashMap<DefId, ResolvedOpaqueTy<'tcx>>,
423434

424435
/// Given the closure ID this map provides the list of UpvarIDs used by it.
425436
/// The upvarID contains the HIR node ID and it also contains the full path

‎src/librustc/ty/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ pub use self::context::{TyCtxt, FreeRegionInfo, GlobalArenas, AllArenas, tls, ke
7474
pub use self::context::{Lift, TypeckTables, CtxtInterners};
7575
pub use self::context::{
7676
UserTypeAnnotationIndex, UserType, CanonicalUserType,
77-
CanonicalUserTypeAnnotation, CanonicalUserTypeAnnotations,
77+
CanonicalUserTypeAnnotation, CanonicalUserTypeAnnotations, ResolvedOpaqueTy,
7878
};
7979

8080
pub use self::instance::{Instance, InstanceDef};

‎src/librustc_typeck/check/mod.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,10 +1386,7 @@ pub fn check_item_type<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, it: &'tcx hir::Ite
13861386
}
13871387
hir::ItemKind::Existential(..) => {
13881388
let def_id = tcx.hir().local_def_id(it.id);
1389-
let pty_ty = tcx.type_of(def_id);
1390-
let generics = tcx.generics_of(def_id);
13911389

1392-
check_bounds_are_used(tcx, &generics, pty_ty);
13931390
let substs = Substs::identity_for_item(tcx, def_id);
13941391
check_opaque(tcx, def_id, substs, it.span);
13951392
}

‎src/librustc_typeck/check/writeback.rs

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -560,21 +560,29 @@ impl<'cx, 'gcx, 'tcx> WritebackCx<'cx, 'gcx, 'tcx> {
560560
if def_id == defin_ty_def_id {
561561
// Concrete type resolved to the existential type itself
562562
// Force a cycle error
563+
// FIXME(oli-obk): we could just not insert it into `concrete_existential_types`
564+
// which simply would make this use not a defining use.
563565
self.tcx().at(span).type_of(defin_ty_def_id);
564566
}
565567
}
566568

569+
let new = ty::ResolvedOpaqueTy {
570+
concrete_type: definition_ty,
571+
substs: self.tcx().lift_to_global(&opaque_defn.substs).unwrap(),
572+
};
573+
567574
let old = self.tables
568575
.concrete_existential_types
569-
.insert(def_id, definition_ty);
576+
.insert(def_id, new);
570577
if let Some(old) = old {
571-
if old != definition_ty {
578+
if old.concrete_type != definition_ty || old.substs != opaque_defn.substs {
572579
span_bug!(
573580
span,
574581
"visit_opaque_types tried to write \
575-
different types for the same existential type: {:?}, {:?}, {:?}",
582+
different types for the same existential type: {:?}, {:?}, {:?}, {:?}",
576583
def_id,
577584
definition_ty,
585+
opaque_defn,
578586
old,
579587
);
580588
}

‎src/librustc_typeck/collect.rs

Lines changed: 101 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ use crate::middle::resolve_lifetime as rl;
2323
use crate::middle::weak_lang_items;
2424
use rustc::mir::mono::Linkage;
2525
use rustc::ty::query::Providers;
26-
use rustc::ty::subst::Substs;
26+
use rustc::ty::subst::{Subst, Substs};
2727
use rustc::ty::util::Discr;
2828
use rustc::ty::util::IntTypeExt;
29+
use rustc::ty::subst::UnpackedKind;
2930
use rustc::ty::{self, AdtKind, ToPolyTraitRef, Ty, TyCtxt};
3031
use rustc::ty::{ReprOptions, ToPredicate};
3132
use rustc::util::captures::Captures;
@@ -1191,7 +1192,7 @@ fn type_of<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) -> Ty<'tcx> {
11911192
tcx.typeck_tables_of(owner)
11921193
.concrete_existential_types
11931194
.get(&def_id)
1194-
.cloned()
1195+
.map(|opaque| opaque.concrete_type)
11951196
.unwrap_or_else(|| {
11961197
// This can occur if some error in the
11971198
// owner fn prevented us from populating
@@ -1323,7 +1324,13 @@ fn find_existential_constraints<'a, 'tcx>(
13231324
struct ConstraintLocator<'a, 'tcx: 'a> {
13241325
tcx: TyCtxt<'a, 'tcx, 'tcx>,
13251326
def_id: DefId,
1326-
found: Option<(Span, ty::Ty<'tcx>)>,
1327+
// First found type span, actual type, mapping from the existential type's generic
1328+
// parameters to the concrete type's generic parameters
1329+
//
1330+
// The mapping is an index for each use site of a generic parameter in the concrete type
1331+
//
1332+
// The indices index into the generic parameters on the existential type.
1333+
found: Option<(Span, ty::Ty<'tcx>, Vec<usize>)>,
13271334
}
13281335

13291336
impl<'a, 'tcx> ConstraintLocator<'a, 'tcx> {
@@ -1338,23 +1345,106 @@ fn find_existential_constraints<'a, 'tcx>(
13381345
.tcx
13391346
.typeck_tables_of(def_id)
13401347
.concrete_existential_types
1341-
.get(&self.def_id)
1342-
.cloned();
1343-
if let Some(ty) = ty {
1348+
.get(&self.def_id);
1349+
if let Some(ty::ResolvedOpaqueTy { concrete_type, substs }) = ty {
13441350
// FIXME(oli-obk): trace the actual span from inference to improve errors
13451351
let span = self.tcx.def_span(def_id);
1346-
if let Some((prev_span, prev_ty)) = self.found {
1347-
if ty != prev_ty {
1352+
// used to quickly look up the position of a generic parameter
1353+
let mut index_map: FxHashMap<ty::ParamTy, usize> = FxHashMap::default();
1354+
// skip binder is ok, since we only use this to find generic parameters and their
1355+
// positions.
1356+
for (idx, subst) in substs.iter().enumerate() {
1357+
if let UnpackedKind::Type(ty) = subst.unpack() {
1358+
if let ty::Param(p) = ty.sty {
1359+
if index_map.insert(p, idx).is_some() {
1360+
// there was already an entry for `p`, meaning a generic parameter
1361+
// was used twice
1362+
self.tcx.sess.span_err(
1363+
span,
1364+
&format!("defining existential type use restricts existential \
1365+
type by using the generic parameter `{}` twice", p.name),
1366+
);
1367+
return;
1368+
}
1369+
} else {
1370+
self.tcx.sess.delay_span_bug(
1371+
span,
1372+
&format!(
1373+
"non-defining exist ty use in defining scope: {:?}, {:?}",
1374+
concrete_type, substs,
1375+
),
1376+
);
1377+
}
1378+
}
1379+
}
1380+
// compute the index within the existential type for each generic parameter used in
1381+
// the concrete type
1382+
let indices = concrete_type
1383+
.subst(self.tcx, substs)
1384+
.walk()
1385+
.filter_map(|t| match &t.sty {
1386+
ty::Param(p) => Some(*index_map.get(p).unwrap()),
1387+
_ => None,
1388+
}).collect();
1389+
let is_param = |ty: ty::Ty| match ty.sty {
1390+
ty::Param(_) => true,
1391+
_ => false,
1392+
};
1393+
if !substs.types().all(is_param) {
1394+
self.tcx.sess.span_err(
1395+
span,
1396+
"defining existential type use does not fully define existential type",
1397+
);
1398+
} else if let Some((prev_span, prev_ty, ref prev_indices)) = self.found {
1399+
let mut ty = concrete_type.walk().fuse();
1400+
let mut p_ty = prev_ty.walk().fuse();
1401+
let iter_eq = (&mut ty).zip(&mut p_ty).all(|(t, p)| match (&t.sty, &p.sty) {
1402+
// type parameters are equal to any other type parameter for the purpose of
1403+
// concrete type equality, as it is possible to obtain the same type just
1404+
// by passing matching parameters to a function.
1405+
(ty::Param(_), ty::Param(_)) => true,
1406+
_ => t == p,
1407+
});
1408+
if !iter_eq || ty.next().is_some() || p_ty.next().is_some() {
13481409
// found different concrete types for the existential type
13491410
let mut err = self.tcx.sess.struct_span_err(
13501411
span,
1351-
"defining existential type use differs from previous",
1412+
"concrete type differs from previous defining existential type use",
1413+
);
1414+
err.span_label(
1415+
span,
1416+
format!("expected `{}`, got `{}`", prev_ty, concrete_type),
1417+
);
1418+
err.span_note(prev_span, "previous use here");
1419+
err.emit();
1420+
} else if indices != *prev_indices {
1421+
// found "same" concrete types, but the generic parameter order differs
1422+
let mut err = self.tcx.sess.struct_span_err(
1423+
span,
1424+
"concrete type's generic parameters differ from previous defining use",
13521425
);
1426+
use std::fmt::Write;
1427+
let mut s = String::new();
1428+
write!(s, "expected [").unwrap();
1429+
let list = |s: &mut String, indices: &Vec<usize>| {
1430+
let mut indices = indices.iter().cloned();
1431+
if let Some(first) = indices.next() {
1432+
write!(s, "`{}`", substs[first]).unwrap();
1433+
for i in indices {
1434+
write!(s, ", `{}`", substs[i]).unwrap();
1435+
}
1436+
}
1437+
};
1438+
list(&mut s, prev_indices);
1439+
write!(s, "], got [").unwrap();
1440+
list(&mut s, &indices);
1441+
write!(s, "]").unwrap();
1442+
err.span_label(span, s);
13531443
err.span_note(prev_span, "previous use here");
13541444
err.emit();
13551445
}
13561446
} else {
1357-
self.found = Some((span, ty));
1447+
self.found = Some((span, concrete_type, indices));
13581448
}
13591449
}
13601450
}
@@ -1413,7 +1503,7 @@ fn find_existential_constraints<'a, 'tcx>(
14131503
}
14141504

14151505
match locator.found {
1416-
Some((_, ty)) => ty,
1506+
Some((_, ty, _)) => ty,
14171507
None => {
14181508
let span = tcx.def_span(def_id);
14191509
tcx.sess.span_err(span, "could not find defining uses");

‎src/test/ui/existential_types/bound_reduction2.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ trait TraitWithAssoc {
88
}
99

1010
existential type Foo<V>: Trait<V>;
11+
//~^ ERROR could not find defining uses
1112

1213
trait Trait<U> {}
1314

1415
impl<W> Trait<W> for () {}
1516

16-
fn foo_desugared<T: TraitWithAssoc>(_: T) -> Foo<T::Assoc> { //~ ERROR non-defining
17+
fn foo_desugared<T: TraitWithAssoc>(_: T) -> Foo<T::Assoc> { //~ ERROR does not fully define
1718
()
1819
}

‎src/test/ui/existential_types/bound_reduction2.stderr

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
error: non-defining existential type use in defining scope
2-
--> $DIR/bound_reduction2.rs:16:1
1+
error: defining existential type use does not fully define existential type
2+
--> $DIR/bound_reduction2.rs:17:1
33
|
4-
LL | / fn foo_desugared<T: TraitWithAssoc>(_: T) -> Foo<T::Assoc> { //~ ERROR non-defining
4+
LL | / fn foo_desugared<T: TraitWithAssoc>(_: T) -> Foo<T::Assoc> { //~ ERROR does not fully define
55
LL | | ()
66
LL | | }
77
| |_^
8-
|
9-
note: used non-generic type <T as TraitWithAssoc>::Assoc for generic parameter
10-
--> $DIR/bound_reduction2.rs:10:22
8+
9+
error: could not find defining uses
10+
--> $DIR/bound_reduction2.rs:10:1
1111
|
1212
LL | existential type Foo<V>: Trait<V>;
13-
| ^
13+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1414

15-
error: aborting due to previous error
15+
error: aborting due to 2 previous errors
1616

‎src/test/ui/existential_types/different_defining_uses.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ fn foo() -> Foo {
99
""
1010
}
1111

12-
fn bar() -> Foo { //~ ERROR defining existential type use differs from previous
12+
fn bar() -> Foo { //~ ERROR concrete type differs from previous
1313
42i32
1414
}

‎src/test/ui/existential_types/different_defining_uses.stderr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
error: defining existential type use differs from previous
1+
error: concrete type differs from previous defining existential type use
22
--> $DIR/different_defining_uses.rs:12:1
33
|
4-
LL | / fn bar() -> Foo { //~ ERROR defining existential type use differs from previous
4+
LL | / fn bar() -> Foo { //~ ERROR concrete type differs from previous
55
LL | | 42i32
66
LL | | }
7-
| |_^
7+
| |_^ expected `&'static str`, got `i32`
88
|
99
note: previous use here
1010
--> $DIR/different_defining_uses.rs:8:1

‎src/test/ui/existential_types/different_defining_uses_never_type.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ fn foo() -> Foo {
99
""
1010
}
1111

12-
fn bar() -> Foo { //~ ERROR defining existential type use differs from previous
12+
fn bar() -> Foo { //~ ERROR concrete type differs from previous
1313
panic!()
1414
}
1515

16-
fn boo() -> Foo { //~ ERROR defining existential type use differs from previous
16+
fn boo() -> Foo { //~ ERROR concrete type differs from previous
1717
loop {}
1818
}

‎src/test/ui/existential_types/different_defining_uses_never_type.stderr

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
error: defining existential type use differs from previous
1+
error: concrete type differs from previous defining existential type use
22
--> $DIR/different_defining_uses_never_type.rs:12:1
33
|
4-
LL | / fn bar() -> Foo { //~ ERROR defining existential type use differs from previous
4+
LL | / fn bar() -> Foo { //~ ERROR concrete type differs from previous
55
LL | | panic!()
66
LL | | }
7-
| |_^
7+
| |_^ expected `&'static str`, got `()`
88
|
99
note: previous use here
1010
--> $DIR/different_defining_uses_never_type.rs:8:1
@@ -14,13 +14,13 @@ LL | | ""
1414
LL | | }
1515
| |_^
1616

17-
error: defining existential type use differs from previous
17+
error: concrete type differs from previous defining existential type use
1818
--> $DIR/different_defining_uses_never_type.rs:16:1
1919
|
20-
LL | / fn boo() -> Foo { //~ ERROR defining existential type use differs from previous
20+
LL | / fn boo() -> Foo { //~ ERROR concrete type differs from previous
2121
LL | | loop {}
2222
LL | | }
23-
| |_^
23+
| |_^ expected `&'static str`, got `()`
2424
|
2525
note: previous use here
2626
--> $DIR/different_defining_uses_never_type.rs:8:1

‎src/test/ui/existential_types/generic_different_defining_uses.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ fn my_iter<T>(t: T) -> MyIter<T> {
88
std::iter::once(t)
99
}
1010

11-
fn my_iter2<T>(t: T) -> MyIter<T> { //~ ERROR defining existential type use differs from previous
11+
fn my_iter2<T>(t: T) -> MyIter<T> { //~ ERROR concrete type differs from previous
1212
Some(t).into_iter()
1313
}

‎src/test/ui/existential_types/generic_different_defining_uses.stderr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
error: defining existential type use differs from previous
1+
error: concrete type differs from previous defining existential type use
22
--> $DIR/generic_different_defining_uses.rs:11:1
33
|
4-
LL | / fn my_iter2<T>(t: T) -> MyIter<T> { //~ ERROR defining existential type use differs from previous
4+
LL | / fn my_iter2<T>(t: T) -> MyIter<T> { //~ ERROR concrete type differs from previous
55
LL | | Some(t).into_iter()
66
LL | | }
7-
| |_^
7+
| |_^ expected `std::iter::Once<T>`, got `std::option::IntoIter<T>`
88
|
99
note: previous use here
1010
--> $DIR/generic_different_defining_uses.rs:7:1

0 commit comments

Comments
 (0)