Skip to content

Commit 46b62b7

Browse files
committed
Auto merge of #3685 - rust-lang:rustup, r=oli-obk
Rustup
2 parents 9d5b148 + 38cdf63 commit 46b62b7

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

clippy_lints/src/arithmetic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic {
128128
}
129129
self.const_span = Some(body_span);
130130
},
131-
hir::BodyOwnerKind::Fn => (),
131+
hir::BodyOwnerKind::Fn | hir::BodyOwnerKind::Closure => (),
132132
}
133133
}
134134

clippy_lints/src/utils/mod.rs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,14 @@ pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
6464
/// ```
6565
pub fn in_constant(cx: &LateContext<'_, '_>, id: NodeId) -> bool {
6666
let parent_id = cx.tcx.hir().get_parent(id);
67-
match cx.tcx.hir().body_owner_kind(parent_id) {
68-
hir::BodyOwnerKind::Fn => false,
69-
hir::BodyOwnerKind::Const | hir::BodyOwnerKind::Static(..) => true,
67+
match cx.tcx.hir().get(parent_id) {
68+
| Node::Item(&Item { node: ItemKind::Const(..), .. })
69+
| Node::TraitItem(&TraitItem { node: TraitItemKind::Const(..), .. })
70+
| Node::ImplItem(&ImplItem { node: ImplItemKind::Const(..), .. })
71+
| Node::AnonConst(_)
72+
| Node::Item(&Item { node: ItemKind::Static(..), .. })
73+
=> true,
74+
_ => false,
7075
}
7176
}
7277

0 commit comments

Comments
 (0)