Skip to content

missing argument in call expression has bad recovery #15683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Sep 29, 2023 · 0 comments · Fixed by #16124
Closed

missing argument in call expression has bad recovery #15683

Veykril opened this issue Sep 29, 2023 · 0 comments · Fixed by #16124
Labels
A-parser parser issues C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented Sep 29, 2023 

fn main() {
	call(a, , b);
}

results in

[email protected]
  [email protected] "fn"
  [email protected] " "
  [email protected]
    [email protected] "main"
  [email protected]
    [email protected] "("
    [email protected] ")"
  [email protected] " "
  [email protected]
    [email protected]
      [email protected] "{"
      [email protected] "\n\t"
      [email protected]
        [email protected]
          [email protected]
            [email protected]
              [email protected]
                [email protected]
                  [email protected] "call"
          [email protected]
            [email protected] "("
            [email protected]
              [email protected]
                [email protected]
                  [email protected]
                    [email protected] "a"
            [email protected] ","
            [email protected] " "
            [email protected]
              [email protected] ","
      [email protected] " "
      [email protected]
        [email protected]
          [email protected]
            [email protected]
              [email protected]
                [email protected] "b"
      [email protected]
        [email protected] ")"
      [email protected] ";"
      [email protected] "\n"
      [email protected] "}"

though ideally it should result in

[email protected]
  [email protected] "fn"
  [email protected] " "
  [email protected]
    [email protected] "main"
  [email protected]
    [email protected] "("
    [email protected] ")"
  [email protected] " "
  [email protected]
    [email protected]
      [email protected] "{"
      [email protected] "\n\t"
      [email protected]
        [email protected]
          [email protected]
            [email protected]
              [email protected]
                [email protected]
                  [email protected] "call"
          [email protected]
            [email protected] "("
            [email protected]
              [email protected]
                [email protected]
                  [email protected]
                    [email protected] "a"
            [email protected] ","
            [email protected] "   "
            [email protected] ","
            [email protected] "   "
            [email protected]
              [email protected]
                [email protected]
                  [email protected]
                    [email protected] "b"
            [email protected] ")"
        [email protected] ";"
      [email protected] "\n"
      [email protected] "}"

diff --git a/current.rast b/ideal.rast
index 09652b246..ca330d497 100644
--- a/current.rast
+++ b/ideal.rast
@@ -11,14 +11,14 @@ [email protected]
     [email protected]
       [email protected] "{"
       [email protected] "\n\t"
-      [email protected]
-        [email protected]
+      [email protected]
+        [email protected]
           [email protected]
             [email protected]
               [email protected]
                 [email protected]
                   [email protected] "call"
-          [email protected]
+          [email protected]
             [email protected] "("
             [email protected]
               [email protected]
@@ -26,18 +26,15 @@ [email protected]
                   [email protected]
                     [email protected] "a"
             [email protected] ","
-            [email protected] " "
-            [email protected]
-              [email protected] ","
-      [email protected] " "
-      [email protected]
-        [email protected]
-          [email protected]
-            [email protected]
-              [email protected]
-                [email protected] "b"
-      [email protected]
-        [email protected] ")"
-      [email protected] ";"
+            [email protected] "   "
+            [email protected] ","
+            [email protected] "   "
+            [email protected]
+              [email protected]
+                [email protected]
+                  [email protected]
+                    [email protected] "b"
+            [email protected] ")"
+        [email protected] ";"
       [email protected] "\n"
       [email protected] "}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser parser issues C-enhancement Category: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Recover from missing argument in call expressions ohno418/rust-analyzer
1 participant
@Veykril