Skip to content

Eager macro breaks token mapping for arguments after a macro #14841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HKalbasi opened this issue May 18, 2023 · 1 comment · Fixed by #14998
Closed

Eager macro breaks token mapping for arguments after a macro #14841

HKalbasi opened this issue May 18, 2023 · 1 comment · Fixed by #14998
Assignees
@Veykril
Labels
A-macro macro expansion C-bug Category: bug

Comments

@HKalbasi
Copy link
Member

HKalbasi commented May 18, 2023 •
edited
Loading 

let a = 2;
format!("{} {} {}", a, vec![2, 3], a);

Go to definition on the first a works correctly, but on the second a will go to the vector internals.

### Tasks
@HKalbasi HKalbasi added the C-bug Category: bug label May 18, 2023
@Veykril Veykril self-assigned this Jun 4, 2023
@Veykril Veykril mentioned this issue Jun 4, 2023
Closed
@Veykril Veykril added the A-macro macro expansion label Jun 4, 2023
@lnicola lnicola mentioned this issue Jun 6, 2023
Closed
@Veykril Veykril mentioned this issue Jun 7, 2023
Merged
@bors bors closed this as completed in 2796851 Jun 9, 2023
@Veykril Veykril reopened this Jun 18, 2023
@Veykril
Copy link
Member

Veykril commented Aug 1, 2023

This should be fixed for good now

@Veykril Veykril closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
A-macro macro expansion C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal: Lazy eager macros Veykril/rust-analyzer
2 participants
@Veykril @HKalbasi