Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Enable defining crate blacklist instead of using rls-blacklist #1303

Closed
h-michael opened this issue Feb 10, 2019 · 4 comments · Fixed by #1509
Closed

Enable defining crate blacklist instead of using rls-blacklist #1303

h-michael opened this issue Feb 10, 2019 · 4 comments · Fixed by #1509
Labels
enhancement Indicates new feature requests

Comments

@h-michael
Copy link
Contributor

If use_crate_blacklist is true, rls ignores analyzing some crates defined in rls-blacklist.
I want to define blacklist by myself.

Are there any reason that rls defines blacklist through rls-blacklist ?

If not, may I implement the feature user defining blacklist instead of using rls-blacklist ?

cc: @nrc

@alexheretic
Copy link
Member

Yes it seems like a good idea to have this simply as config with a default.

I'm not sure why it's a separate crate, I don't think I'd have even put it in a separate module, it's literally:

pub const CRATE_BLACKLIST: [&'static str; 13] = [
    "cocoa",
    "gleam",
    "glium",
    "idna",
    "libc",
    "openssl",
    "rustc_serialize",
    "serde",
    "serde_json",
    "typenum",
    "unicode_normalization",
    "unicode_segmentation",
    "winapi",
];

@h-michael
Copy link
Contributor Author

I've implemented it.
I waiting for merging #1299.
Becaus it's implementation incluse some crates change. :)

@alexheretic
Copy link
Member

Is the crate used in any of the other crates? Maybe that was the reason...

@h-michael
Copy link
Contributor Author

It needs a littele rls-analysis changes.
But it is a bit problem.
So I'll create PR after sone hours. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants