Skip to content

Error on test that should panic in num-complex #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kungfukennyg opened this issue Jun 13, 2019 · 5 comments
Closed

Error on test that should panic in num-complex #770

kungfukennyg opened this issue Jun 13, 2019 · 5 comments

Comments

@kungfukennyg
Copy link
Contributor

Miri panics and fails when running a test marked with #[should_panic] in the num-complex crate.

The test in question:

    #[should_panic]
    fn test_divide_by_zero_natural() {
        let n = Complex::new(2, 3);
        let d = Complex::new(0, 0);
        let _x = n / ```

Log: https://gist.github.com/kennethbgoodin/f648b0164557faaca30584fcc456605e
@bjorn3
Copy link
Member

bjorn3 commented Jun 13, 2019

Miri doesn't support unwinding yet. You may want to wait for #693.

@kungfukennyg
Copy link
Contributor Author

kungfukennyg commented Jun 13, 2019

Thank you for the information. I figured as much, added the issue so I can reference it elsewhere.

@RalfJung
Copy link
Member

This is a duplicate of #658.

@RalfJung
Copy link
Member

Oh, also, try

cargo miri test -- -- -Zunstable-options --exclude-should-panic

to skip those tests.

@kungfukennyg
Copy link
Contributor Author

kungfukennyg commented Jun 13, 2019

Oh thanks! That's helpful. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants