Skip to content

Clarify in data race errors when a Read or Write is actually from the aliasing model #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saethlin opened this issue Jun 8, 2023 · 2 comments
Labels
A-diagnostics errors and warnings emitted by miri

Comments

@saethlin
Copy link
Member

saethlin commented Jun 8, 2023

Since #2648 it is possible to have a data race reported which points at code and says it does a Read or a Write, when there is actually no memory access in said code. The fact that a reborrow can even be relevant for data races is on itself surprising, and if a user is not already familiar with the fact that the aliasing model and data race models interact, these diagnostics can look like a bug.

See #2920 for an example of a surprised user.

@RalfJung
Copy link
Member

RalfJung commented Jun 8, 2023

The same applies to Tree Borrows.

@RalfJung
Copy link
Member

Fixed by #3385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics errors and warnings emitted by miri
Projects
None yet
Development

No branches or pull requests

2 participants