Skip to content

Allow blessing test stdout/stderr #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aaron1011 opened this issue Oct 20, 2020 · 5 comments
Closed

Allow blessing test stdout/stderr #1588

Aaron1011 opened this issue Oct 20, 2020 · 5 comments
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@Aaron1011
Copy link
Member

Currently, I need to update the captured stdout/stderr for each test individually whenever it changes. It would be nice to have a ./miri test --bless mode, which would work like ./x.py test --bless

@RalfJung
Copy link
Member

Yeah, that would definitely be nice. Unfortunately I have no idea what would be a good way to do this.

I am also not sure if it is worth sinking more effort into our compiletest-based infrastructure (the non-rustc version of that crate is barely maintained) or if we can use https://github.com/dtolnay/trybuild instead.

@RalfJung RalfJung added A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Oct 20, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2020

Another alternative is to use assert_cmd like in https://github.com/davidbarsky/tracing-tree/pull/21/files (if trybuild doesn't give us the control we ened)

@camelid
Copy link
Member

camelid commented Oct 23, 2020

@rustbot claim

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2020

Error: This repository is not enabled to use triagebot.
Add a triagebot.toml in the root of the master branch to enable it.

Please let @rust-lang/release know if you're having trouble with this bot.

@saethlin
Copy link
Member

@RalfJung I think this is done now?

@oli-obk oli-obk closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

No branches or pull requests

6 participants