Skip to content

Add versioning to the binary profile format #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwoerister opened this issue May 2, 2019 · 0 comments · Fixed by #41
Closed

Add versioning to the binary profile format #40

michaelwoerister opened this issue May 2, 2019 · 0 comments · Fixed by #41
Labels
enhancement New feature or request

Comments

@michaelwoerister
Copy link
Member

Right now the files generated by rustc -Zself-profile don't contain any indication of what their concrete encoding is. That should change so that post-processing tools support more than one version or at least give a sensible error message when encountering an unsupported encoding.

For example, each file could start with a some file magic (b"MMES" for the event stream, b"MMSD" for the string table data, and b"MMSI" for the string table index) and a 4 byte little-endian version number that can be used to select the right decoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant