Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

The stable feature seems backwards #212

Closed
Lokathor opened this issue Jul 28, 2019 · 1 comment
Closed

The stable feature seems backwards #212

Lokathor opened this issue Jul 28, 2019 · 1 comment

Comments

@Lokathor
Copy link
Contributor

With the current setup, the stable feature allows you to build the crate on stable, and removing it adds some speed boosts but requires nightly. However, once a dependency is flipped no by any crate in the graph, all crates get that feature on, so features should be purely additive whenever possible.

Accordingly, the meaning should be flipped around: stable is default, and unstable intrinsic usage is enabled with a feature flag being turned on if the user wants that boost.

@Lokathor
Copy link
Contributor Author

Closed by #224

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant