diff --git a/src/docbuilder/rustwide_builder.rs b/src/docbuilder/rustwide_builder.rs index 36c948507..b9559b70f 100644 --- a/src/docbuilder/rustwide_builder.rs +++ b/src/docbuilder/rustwide_builder.rs @@ -809,7 +809,7 @@ mod tests { fn test_build_crate() { wrapper(|env| { let crate_ = DUMMY_CRATE_NAME; - let crate_path = crate_.replace("-", "_"); + let crate_path = crate_.replace('-', "_"); let version = DUMMY_CRATE_VERSION; let default_target = "x86_64-unknown-linux-gnu"; @@ -1020,7 +1020,7 @@ mod tests { assert!(storage.exists(&source_archive)?, "{}", source_archive); let target = "x86_64-unknown-linux-gnu"; - let crate_path = crate_.replace("-", "_"); + let crate_path = crate_.replace('-', "_"); let target_docs_present = storage.exists_in_archive( &doc_archive, &format!("{}/{}/index.html", target, crate_path), diff --git a/src/storage/s3.rs b/src/storage/s3.rs index cd55f2579..9ef6c5d7e 100644 --- a/src/storage/s3.rs +++ b/src/storage/s3.rs @@ -271,7 +271,7 @@ impl<'a> StorageTransaction for S3StorageTransaction<'a> { let to_delete = list .contents - .unwrap_or_else(Vec::new) + .unwrap_or_default() .into_iter() .filter_map(|o| o.key) .map(|key| ObjectIdentifier { diff --git a/src/web/routes.rs b/src/web/routes.rs index 2e7a2290e..2f0e77aa5 100644 --- a/src/web/routes.rs +++ b/src/web/routes.rs @@ -270,6 +270,7 @@ impl Routes { pattern.to_string(), Box::new(RequestRecorder::new( SimpleRedirect::new(|url| { + #[allow(clippy::unnecessary_to_owned)] url.set_path(&url.path().trim_end_matches('/').to_string()) }), pattern, diff --git a/src/web/rustdoc.rs b/src/web/rustdoc.rs index 94f7ce972..bf5e23e2a 100644 --- a/src/web/rustdoc.rs +++ b/src/web/rustdoc.rs @@ -1123,7 +1123,7 @@ mod test { .name(name) .version(version) .archive_storage(archive_storage) - .rustdoc_file(&(name.replace("-", "_") + "/index.html")) + .rustdoc_file(&(name.replace('-', "_") + "/index.html")) .create()?; }