Skip to content

Commit ee92e94

Browse files
committed
Don't delete the whole crate from s3, just this version
Oops.
1 parent d58aa7d commit ee92e94

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/db/delete.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ pub fn delete_version(conn: &Connection, name: &str, version: &str) -> Result<()
2929

3030
if let Some(s3) = s3_client() {
3131
for prefix in STORAGE_PATHS_TO_DELETE {
32-
delete_prefix_from_s3(&s3, &format!("{}/{}/", prefix, name))?;
32+
delete_prefix_from_s3(&s3, &format!("{}/{}/{}/", prefix, name, version))?;
3333
}
3434
}
3535

@@ -184,7 +184,7 @@ fn delete_prefix_from_s3(s3: &S3Client, name: &str) -> Result<(), Error> {
184184
#[cfg(test)]
185185
mod tests {
186186
use super::*;
187-
use crate::test::wrapper;
187+
use crate::test::{assert_success, wrapper};
188188
use failure::Error;
189189
use postgres::Connection;
190190

@@ -294,6 +294,10 @@ mod tests {
294294
vec!["Peter Rabbit".to_string()]
295295
);
296296

297+
let web = env.frontend();
298+
assert_success("/a/2.0.0/a/", web)?;
299+
assert_eq!(web.get("/a/1.0.0/a/").send()?.status(), 404);
300+
297301
Ok(())
298302
})
299303
}

0 commit comments

Comments
 (0)