Skip to content

Commit a93163d

Browse files
committed
fix first test
1 parent 2db23d5 commit a93163d

File tree

2 files changed

+23
-19
lines changed

2 files changed

+23
-19
lines changed

src/web/builds.rs

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -328,29 +328,25 @@ mod tests {
328328

329329
let response = env.frontend().get("/crate/foo/0.1.0/builds").send()?;
330330

331-
// FIXME: temporarily we don't show in-progress releases anywhere, which means we don't
332-
// show releases without builds anywhere.
333-
assert_eq!(response.status(), StatusCode::NOT_FOUND);
334-
335-
// assert_cache_control(&response, CachePolicy::NoCaching, &env.config());
336-
// let page = kuchikiki::parse_html().one(response.text()?);
331+
assert_cache_control(&response, CachePolicy::NoCaching, &env.config());
332+
let page = kuchikiki::parse_html().one(response.text()?);
337333

338-
// let rows: Vec<_> = page
339-
// .select("ul > li a.release")
340-
// .unwrap()
341-
// .map(|row| row.text_contents())
342-
// .collect();
334+
let rows: Vec<_> = page
335+
.select("ul > li a.release")
336+
.unwrap()
337+
.map(|row| row.text_contents())
338+
.collect();
343339

344-
// assert!(rows.is_empty());
340+
assert!(rows.is_empty());
345341

346-
// let warning = page
347-
// .select_first(".warning")
348-
// .expect("missing warning element")
349-
// .text_contents();
342+
let warning = page
343+
.select_first(".warning")
344+
.expect("missing warning element")
345+
.text_contents();
350346

351-
// assert!(warning.contains("has not built"));
352-
// assert!(warning.contains("queued"));
353-
// assert!(warning.contains("open an issue"));
347+
assert!(warning.contains("has not built"));
348+
assert!(warning.contains("queued"));
349+
assert!(warning.contains("open an issue"));
354350

355351
Ok(())
356352
});

templates/crate/builds.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,14 @@
8585
</li>
8686
{%- endfor -%}
8787
</ul>
88+
{%- else -%}
89+
<div class="warning">
90+
docs.rs has not built {{ metadata.name }}-{{ metadata.version }}
91+
<br>
92+
It may still be <a href="/releases/queue">queued</a> or in-progress.
93+
<br>
94+
If you believe this is docs.rs' fault, <a href="https://github.com/rust-lang/docs.rs/issues/new/choose">open an issue</a>.
95+
</div>
8896
{%- endif -%}
8997

9098
<div class="about">

0 commit comments

Comments
 (0)