Skip to content

Commit ca4edab

Browse files
committed
Auto merge of #10706 - merelymyself:master, r=epage
Guide new users to add use `super::*;` to `mod test` ### What does this PR try to resolve? Currently, `cargo init --lib` produces examples for unit tests. However, new users will find that they are unable to use functions they defined above. This should resolve the confusion. Fixes #10559 ### How should we test and review this PR? This PR does not create new features. Test this PR using the already-existing tests. ### Additional information I didn't think this was a major change, so I did not open a RFC for it. Please let me know if I should have!
2 parents e0e1df9 + 754a5bf commit ca4edab

File tree

15 files changed

+106
-16
lines changed

15 files changed

+106
-16
lines changed

src/cargo/ops/cargo_new.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,11 +809,17 @@ fn main() {
809809
"
810810
} else {
811811
b"\
812+
pub fn add(left: usize, right: usize) -> usize {
813+
left + right
814+
}
815+
812816
#[cfg(test)]
813817
mod tests {
818+
use super::*;
819+
814820
#[test]
815821
fn it_works() {
816-
let result = 2 + 2;
822+
let result = add(2, 2);
817823
assert_eq!(result, 4);
818824
}
819825
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
pub fn add(left: usize, right: usize) -> usize {
2+
left + right
3+
}
4+
15
#[cfg(test)]
26
mod tests {
7+
use super::*;
8+
39
#[test]
410
fn it_works() {
5-
let result = 2 + 2;
11+
let result = add(2, 2);
612
assert_eq!(result, 4);
713
}
814
}

tests/testsuite/new.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,17 @@ fn simple_lib() {
3939
let contents = fs::read_to_string(&lib).unwrap();
4040
assert_eq!(
4141
contents,
42-
r#"#[cfg(test)]
42+
r#"pub fn add(left: usize, right: usize) -> usize {
43+
left + right
44+
}
45+
46+
#[cfg(test)]
4347
mod tests {
48+
use super::*;
49+
4450
#[test]
4551
fn it_works() {
46-
let result = 2 + 2;
52+
let result = add(2, 2);
4753
assert_eq!(result, 4);
4854
}
4955
}

0 commit comments

Comments
 (0)