fix clippy warnings:

manual_range_contains
needless_lifetimes

Author: matthiaskrgr

crates/cargo-platform/src/cfg.rs

@@ -298,11 +298,11 @@ impl<'a> Iterator for Tokenizer<'a> {
 }
 
 fn is_ident_start(ch: char) -> bool {
-    ch == '_' || ('a' <= ch && ch <= 'z') || ('A' <= ch && ch <= 'Z')
+    ch == '_' || ('a'..='z').contains(&ch) || ('A'..='Z').contains(&ch)
 }
 
 fn is_ident_rest(ch: char) -> bool {
-    is_ident_start(ch) || ('0' <= ch && ch <= '9')
+    is_ident_start(ch) || ('0'..='9').contains(&ch)
 }
 
 impl<'a> Token<'a> {

src/cargo/core/package.rs

@@ -430,7 +430,7 @@ impl<'cfg> PackageSet<'cfg> {
         })
     }
 
-    pub fn package_ids<'a>(&'a self) -> impl Iterator<Item = PackageId> + 'a {
+    pub fn package_ids(&self) -> impl Iterator<Item = PackageId> + '_ {
         self.packages.keys().cloned()
     }
 

src/cargo/core/resolver/resolve.rs

@@ -236,7 +236,7 @@ unable to verify that `{0}` is the same as when the lockfile was generated
         self.graph.sort()
     }
 
-    pub fn iter<'a>(&'a self) -> impl Iterator<Item = PackageId> + 'a {
+    pub fn iter(&self) -> impl Iterator<Item = PackageId> + '_ {
         self.graph.iter().cloned()
     }
 

src/cargo/core/resolver/types.rs

@@ -184,7 +184,7 @@ impl DepsFrame {
             .unwrap_or(0)
     }
 
-    pub fn flatten<'a>(&'a self) -> impl Iterator<Item = (PackageId, Dependency)> + 'a {
+    pub fn flatten(&self) -> impl Iterator<Item = (PackageId, Dependency)> + '_ {
         self.remaining_siblings
             .clone()
             .map(move |(d, _, _)| (self.parent.package_id(), d))
@@ -258,7 +258,7 @@ impl RemainingDeps {
         }
         None
     }
-    pub fn iter<'a>(&'a mut self) -> impl Iterator<Item = (PackageId, Dependency)> + 'a {
+    pub fn iter(&mut self) -> impl Iterator<Item = (PackageId, Dependency)> + '_ {
         self.data.iter().flat_map(|(other, _)| other.flatten())
     }
 }

src/cargo/sources/registry/index.rs

@@ -747,7 +747,7 @@ impl IndexSummary {
     }
 }
 
-fn split<'a>(haystack: &'a [u8], needle: u8) -> impl Iterator<Item = &'a [u8]> + 'a {
+fn split(haystack: &[u8], needle: u8) -> impl Iterator<Item = &[u8]> + '_ {
     struct Split<'a> {
         haystack: &'a [u8],
         needle: u8,

src/cargo/util/errors.rs

@@ -470,7 +470,7 @@ pub fn is_simple_exit_code(code: i32) -> bool {
     // codes are very large. This is just a rough
     // approximation of which codes are "normal" and which
     // ones are abnormal termination.
-    code >= 0 && code <= 127
+    (0..=127).contains(&code)
 }
 
 pub fn internal<S: fmt::Display>(error: S) -> anyhow::Error {