-
Notifications
You must be signed in to change notification settings - Fork 469
Add dev container #6851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree that this would be useful, but I think most of the contributors are not very familiar with it. As far as I know, including the devcontainer in the project path is optional, and can be provided in a different path. Perhaps you can have a devcontainer image from a separate project and introduce it here. |
I can give this a shot but I'm rather fuzzy on what needs to happen in https://github.com/rescript-lang/rescript-compiler/blob/master/CONTRIBUTING.md#setup
|
@cknitt yes, thank you, I'm already playing with this in https://github.com/nojaf/rescript-compiler/tree/devcontainer. Are you ok with some changes to the Dockerfile? One I think we need is having a separate user because dev containers don't work well when the user is root. Would it be ok to move the |
Yes, please feel free to make any required changes. 👍 |
It would be great if this repository had a devcontainer with all the requirements included.
Then people can just clone the repo and spin a container that has all the bits they need to compile everything.
If approved, I'm willing to contribute this (although I'll might have some questions)
The text was updated successfully, but these errors were encountered: