Skip to content

Add dev container #6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nojaf opened this issue Jul 4, 2024 · 5 comments · Fixed by #6962
Closed

Add dev container #6851

nojaf opened this issue Jul 4, 2024 · 5 comments · Fixed by #6962

Comments

@nojaf
Copy link
Collaborator

nojaf commented Jul 4, 2024

It would be great if this repository had a devcontainer with all the requirements included.

Then people can just clone the repo and spin a container that has all the bits they need to compile everything.

If approved, I'm willing to contribute this (although I'll might have some questions)

@cometkim
Copy link
Member

I agree that this would be useful, but I think most of the contributors are not very familiar with it.

As far as I know, including the devcontainer in the project path is optional, and can be provided in a different path. Perhaps you can have a devcontainer image from a separate project and introduce it here.

@nojaf
Copy link
Collaborator Author

nojaf commented Aug 5, 2024

I can give this a shot but I'm rather fuzzy on what needs to happen in https://github.com/rescript-lang/rescript-compiler/blob/master/CONTRIBUTING.md#setup

C compiler toolchain and opam are tricky for me.
What exactly would that be in say Ubuntu/Debian terms?
(For opam, the proper initial setup is confusing to me)

@cknitt
Copy link
Member

cknitt commented Aug 15, 2024

@nojaf I added a Dockerfile in #6951 - can you take it from here and create the dev container definition?

@nojaf
Copy link
Collaborator Author

nojaf commented Aug 15, 2024

@cknitt yes, thank you, I'm already playing with this in https://github.com/nojaf/rescript-compiler/tree/devcontainer.

Are you ok with some changes to the Dockerfile? One I think we need is having a separate user because dev containers don't work well when the user is root. Would it be ok to move the Dockerfile into the .devcontainer folder?

@cknitt
Copy link
Member

cknitt commented Aug 15, 2024

Yes, please feel free to make any required changes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants