Skip to content

Make react theme production ready #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thangngoc89 opened this issue Mar 6, 2018 · 0 comments
Closed

Make react theme production ready #2579

thangngoc89 opened this issue Mar 6, 2018 · 0 comments
Assignees
@chenglou @glennsl

Comments

@thangngoc89
Copy link
Contributor

thangngoc89 commented Mar 6, 2018 •
edited
Loading

Currently, the react theme (created with bsb -init my-app -theme react) is not production ready. And people complains about hello world app size.

I added some improvements to the react theme and it's now on bar with CRA hello world bundle (~118 KB before gzip)

What I did:

  • react 16
  • webpack 4 with production mode
  • es6 module (for tree-shaking bs-platform's stdlibs)

The result is here https://github.com/thangngoc89/reason-react-boilerplate and I would love for this to be merged upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenglou chenglou

@glennsl glennsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chenglou @thangngoc89 @glennsl