Skip to content

Treat stdlib as normal package #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobzhang opened this issue Feb 8, 2017 · 3 comments
Closed

Treat stdlib as normal package #1187

bobzhang opened this issue Feb 8, 2017 · 3 comments
Labels
stale Old issues that went stale

Comments

@bobzhang
Copy link
Member

bobzhang commented Feb 8, 2017

In bsconfig.json, adding a new attribute stdlib which defaults to true

The reason is that if we install bs-platform globally and do a symlink, the path resolution would still go to the absolute path which still works but may not be what we want.

The other benefit is that OCaml's stdlib is not really tailored for JS backend, this leaves more choices later.
So the compiler will always add a -nostdlib and based on user option to pick up the stdlib path.

If we treat stdlib as a normal package, make sure clean-world will not clean it and make-world will not build it...

@bobzhang
Copy link
Member Author

bobzhang commented Feb 8, 2017

it will affect internal package dependency handling, you need query bs-dependencies and use-stdlib (get_package_specs) to get it correct.
Again, if we have a global view of dependencies, we can deal with duplicated packages, then this will be solved in a consistent style without exceptions

@bobzhang
Copy link
Member Author

bobzhang commented Feb 8, 2017

Treat stdlib as a normal ocaml package requires more work(interaction with -make-world, -clean-world and duplicated packages etc), let's add a quick hack for -I, and tune better global views later

@stale
Copy link

stale bot commented Jan 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Old issues that went stale label Jan 15, 2021
@stale stale bot closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

1 participant