Skip to content

Add Dict.map #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Minnozz opened this issue Jan 15, 2024 · 4 comments · Fixed by #181
Closed

Add Dict.map #179

Minnozz opened this issue Jan 15, 2024 · 4 comments · Fixed by #181

Comments

@Minnozz
Copy link
Contributor

Minnozz commented Jan 15, 2024

I was migrating a library to use @rescript/core and was unable to find an alternative for Js.Dict.map in either Belt or this library. Should it be added?
@Minnozz
Copy link
Contributor Author

Minnozz commented Jan 15, 2024

For reference, the implementation of Js.Dict.map:
https://github.com/rescript-lang/rescript-compiler/blob/0bd73673276decaf5a35116a0a28a3d67887d881/jscomp/others/js_dict.res#L115-L124

@zth
Copy link
Collaborator

zth commented Jan 17, 2024

Oh yeah, that definitely sounds like a good idea. Care to PR?

@DZakh
Copy link
Member

DZakh commented Jan 17, 2024

Should we call it mapValues? Like it's in lodash https://lodash.com/docs/4.17.15#mapValues

Also, https://lodash.com/docs/4.17.15#mapKeys can be handy as well

@Minnozz Minnozz changed the title Add Dict.map? Add Dict.map Jan 19, 2024
@Minnozz Minnozz mentioned this issue Jan 19, 2024
Merged
@Minnozz
Copy link
Contributor Author

Minnozz commented Jan 19, 2024

I added mapValues and some other bindings that I needed in #181.

@zth zth closed this as completed in #181 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dict: add forEach, forEachWithKey, mapValues Minnozz/rescript-core
3 participants
@Minnozz @zth @DZakh