Merge pull request #796 from gcanti/add-prefix-to-randomly-generated-type

gaearon · gaearon · commit 78c29b7efc25 · 2015-09-26T00:56:54.000+03:00
Add prefix to randomly generated action type in combineReducers #792
diff --git a/src/utils/combineReducers.js b/src/utils/combineReducers.js
@@ -85,7 +85,7 @@ export default function combineReducers(reducers) {
       );
     }
 
-    var type = Math.random().toString(36).substring(7).split('').join('.');
+    var type = '@@redux/PROBE_UNKNOWN_ACTION_' + Math.random().toString(36).substring(7).split('').join('.');
     if (!sanityError && typeof reducer(undefined, { type }) === 'undefined') {
       sanityError = new Error(
         `Reducer "${key}" returned undefined when probed with a random type. ` +

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ export default function combineReducers(reducers) {`
`85`	`85`	`);`
`86`	`86`	`}`
`87`	`87`
`88`		`- var type = Math.random().toString(36).substring(7).split('').join('.');`
	`88`	`+ var type = '@@redux/PROBE_UNKNOWN_ACTION_' + Math.random().toString(36).substring(7).split('').join('.');`
`89`	`89`	`if (!sanityError && typeof reducer(undefined, { type }) === 'undefined') {`
`90`	`90`	`sanityError = new Error(`
`91`	`91`	`Reducer "${key}" returned undefined when probed with a random type. ` +