-
Notifications
You must be signed in to change notification settings - Fork 651
Bug: React 16.0.0 breaks Transition #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The api there hasn't changed in v16 of React so I'm not sure what could break. I'm not seeing this error |
@jquense I don't remember seeing any API changes listed in the docs either, but something certainly seems different! |
I am seeing this as well. Looks like |
the issue is that no code here is calling that. sounds like maybe you forgot to upgrade react-dom as well? |
@jquense and @taylorlapeyre I saw this issue described in #151 and based on what I read there it looks like the issue has to do with having multiple version of react in your deps. I am using yarn, so I went ahead an manually edited the yarn.lock to remove the react 15 bundle that was still being installed. This cause some of my packages to to complain about having the wrong peer-dependencies, but all my tests are passing, and app is working well. TLDR; This is not an issue with react-transition-group |
Thanks @duro ! |
Multiple versions of react might happen when there's another package depending on it. |
Seems like this library needs to accommodate React's new updating system?
The text was updated successfully, but these errors were encountered: